rhythmbox error report "Unknown playback error" needs improvement

Bug #79445 reported by Bryce Harrington
12
Affects Status Importance Assigned to Milestone
Rhythmbox
Fix Released
Medium
rhythmbox (Ubuntu)
Fix Released
Low
Ubuntu Desktop Bugs
Declined for Hardy by Sebastien Bacher

Bug Description

Binary package hint: rhythmbox

A common error message reported by rhythmbox is "Unknown playback error", which isn't very illuminating or helpful.

Looking through the codebase, there are three different codepaths that can generate this error message. Attached is a patch to improve the error message to help in narrowing down which of the codepaths hit the error.

Revision history for this message
Bryce Harrington (bryce) wrote :
Revision history for this message
Bryce Harrington (bryce) wrote :

Btw, this is against 0.9.7-ubuntu4 and tested on feisty.

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for the work on that Bryce, I've forwarded the bug and patch upstream: http://bugzilla.gnome.org/show_bug.cgi?id=397196

Changed in rhythmbox:
assignee: nobody → desktop-bugs
importance: Undecided → Low
status: Unconfirmed → Confirmed
Changed in rhythmbox:
status: Unknown → Unconfirmed
Revision history for this message
Sebastien Bacher (seb128) wrote :

Upstream comment:

"I'm not entirely certain that "Failed to sync gstreamer pipeline in open
operation" or "Failed to set gstreamer element state" is any more enlightening
than "Unknown playback error" for most people. It would also mean that
translators have to translate those too."

Revision history for this message
Kent Borg (kentborg) wrote :

How about where XMMS says "Server reported: 403 max listeners reached", could Rhythmbox say something more informative than "Unknown playback error"? This makes XMMS look smart and Rhythmbox look dim.

-kb, the Kent who uses XMMS just to know whether a stream is full as opposed to other problems, like the URL having moved.

Revision history for this message
Lin (baumbachlm) wrote :

Audio sounds are not working.... I tried to run rhythmbox also and got the message "Unknown Playback Error"... I tried ---

rhythmbox-0.9.7-bryce/backends/gstreamer/rb-player-gst.c 2007-01-15 12:07:15.000000000 -0800
+++ rhythmbox-0.9.7/backends/gstreamer/rb-player-gst.c 2006-12-11 04:36:58.000000000 -0800
@@ -695,7 +695,7 @@
  * error from the sequence into error.
  */
 static void
-end_gstreamer_operation (RBPlayerGst *mp, gboolean op_failed, const gchar* errormsg, GError **error)
+end_gstreamer_operation (RBPlayerGst *mp, gboolean op_failed, GError **error)
 {
  mp->priv->can_signal_direct_error = FALSE;
  if (mp->priv->error) {
@@ -705,7 +705,7 @@
   g_set_error (error,
         RB_PLAYER_ERROR,
         RB_PLAYER_ERROR_GENERAL,
- errormsg);
+ _("Unknown playback error"));
  }
 }

@@ -821,12 +821,12 @@
  }

  if (!rb_player_gst_sync_pipeline (mp)) {
- end_gstreamer_operation (mp, TRUE, _("Failed to sync gstreamer pipeline in open operation"), error);
+ end_gstreamer_operation (mp, TRUE, error);
   rb_player_gst_close (player, NULL);
   return FALSE;
  }

- end_gstreamer_operation (mp, FALSE, NULL, error);
+ end_gstreamer_operation (mp, FALSE, error);
  return TRUE;
 }

@@ -873,7 +873,7 @@
 #elif HAVE_GSTREAMER_0_10
  ret = gst_element_set_state (mp->priv->playbin, GST_STATE_READY) == GST_STATE_CHANGE_SUCCESS;
 #endif
- end_gstreamer_operation (mp, !ret, _("Failed to set gstreamer element state"), error);
+ end_gstreamer_operation (mp, !ret, error);
  return ret;
 }

@@ -898,7 +898,7 @@

  begin_gstreamer_operation (mp);
  ret = rb_player_gst_sync_pipeline (mp);
- end_gstreamer_operation (mp, !ret, _("Failed to sync gstreamer pipeline in play operation"), error);
+ end_gstreamer_operation (mp, !ret, error);
  return ret;
 }

But I have no idea where it goes. Can someone help
Thanks Ahead of Time

Changed in rhythmbox:
status: Confirmed → Triaged
Revision history for this message
erk42084 (erk42084) wrote :

new to ubuntu. downloaded a music file and it started out playing just fine. after a few songs it gave me the error msg "unkown playback error." plz help

Changed in rhythmbox:
status: New → Fix Released
Revision history for this message
Sebastien Bacher (seb128) wrote :

the bug has been fixed upstream now

Changed in rhythmbox (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Martin Mai (mrkanister-deactivatedaccount-deactivatedaccount) wrote :

Version 0.12.2 fixed this (line 120 in http://git.gnome.org/cgit/rhythmbox/tree/NEWS?id=05020b29c17e5b7eb9391eca3e1d6b300fa77ec7) and is present in karmic for a month now. Closing this bug.

Changed in rhythmbox (Ubuntu):
status: Fix Committed → Fix Released
Changed in rhythmbox:
importance: Unknown → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.