Odoo Addons (MOVED TO GITHUB)

hr_expense: invoice ignores employee company

Bug #796363 reported by Stéphane Bidoul (Acsone) on 2011-06-12

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	Odoo Addons (MOVED TO GITHUB)	Fix Released	Low	OpenERP R&D Addons Team 3	Odoo Addons (MOVED TO GITHUB) 6.1

Bug Description

Hi,

When creating an invoice from an expense (the last step in hr_expense workflow), the employee company is ignored.

How to reproduce:
- create 2 companies A and B
- create an expense for an employee of company B
- approve and invoice the expense with the user where company preference is set to A
- result: the invoice is created for company A
- expected result: the invoice should be created for company B which is the company of the employee submitting the expense, not the default company of the user creating the invoice

I attach a patch.

Best regards,

-sbi

Related branches

lp:~openerp-dev/openobject-addons/trunk-bug-796363-uco

Merged into lp:openobject-addons at revision 5163

Mustufa Rangwala (Open ERP) (community): Approve on 2011-06-17

Ujjvala Collins (community): Needs Resubmitting on 2011-06-17

qdp (OpenERP): Pending requested 2011-06-16

lp:openobject-addons

Revision history for this message

Stéphane Bidoul (Acsone) (sbi) wrote on 2011-06-12:

expense_invoice_multi_company.patch Edit (2.0 KiB, text/plain)

Revision history for this message

Stéphane Bidoul (Acsone) (sbi) wrote on 2011-06-12:

expense_invoice_multi_company.patch Edit (3.5 KiB, text/plain)

Hi again,

I attach a slightly improved patch: the company_id used to create the invoice is taken from the expense instead of the expense employee. In turn, the company_id on the expense is defaulted to the employee company. This creates a sensible default, while allowing the user to create an expense for another company than its own.

Best regards,

-sbi

Revision history for this message

Amit Parik (amit-parik) wrote on 2011-06-13:

Hello,

In trunk just add also "import netsvc" which is missing in hr_expense.py

Thanks.

summary:	- [6.0] hr_expense: invoice ignores employee company + hr_expense: invoice ignores employee company
Changed in openobject-addons:
assignee:	nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
importance:	Undecided → Low
status:	New → Confirmed

Ujjvala Collins (uco-openerp) on 2011-06-13

Changed in openobject-addons:
status:	Confirmed → In Progress

Revision history for this message

Ujjvala Collins (uco-openerp) wrote on 2011-06-15:

Hello Stéphane,

Thanks for the patch. I have made some small corrections and committed your patch in the following branch:
lp:~openerp-dev/openobject-addons/trunk-bug-796363-uco with revision 4780 <email address hidden>.

Thanks for reporting the problem. This will be merged into main addons soon.

Thanks,
Ujjvala

Changed in openobject-addons:
status:	In Progress → Fix Committed

Revision history for this message

Stéphane Bidoul (Acsone) (sbi) wrote on 2011-06-15:

Hi Ujjvala,

In the meantime, I've had a stack trace with my patch: I noticed it's better to use browse instead of read in _company_get.

Best regards,

-sbi

Mustufa Rangwala (Open ERP) (mra-tinyerp) on 2011-06-16

Changed in openobject-addons:
milestone:	none → 6.1

Revision history for this message

Ujjvala Collins (uco-openerp) wrote on 2011-06-17:

Hello Stéphane,

Thanks for the suggestion. I have improved the code accordingly.

Regards,
Ujjvala

Revision history for this message

Ujjvala Collins (uco-openerp) wrote on 2011-06-17:

Hello Stéphane,

We have removed the function _company_get, adding the default value to the company_id field, from your code, as it is achieved by the onchange_employee_id method. Rest of the changes are working fine. We'll apply them in trunk-addons soon.

Thank you very much for your contribution.

Regards,
Ujjvala

Fabien (Open ERP) (fp-tinyerp) on 2011-09-24