OpenStack Compute (nova)

FLAGS.allow_admin_api should be turned into a decorator

Bug #801652 reported by Josh Kearney on 2011-06-24

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Compute (nova)	Won't Fix	Undecided	Unassigned

Instead of checking the value of FLAGS.allow_admin_api everywhere, this should be made into a decorator.

Revision history for this message

Sandy Walsh (sandy-walsh) wrote on 2011-06-24:

It's only checked once at route creation time. If you put it in a decorator, can you still define the correct routes?

Revision history for this message

Josh Kearney (jk0) wrote on 2011-06-24:

Good question. I suggested this in the event that we start using it in more places.

Revision history for this message

Sandy Walsh (sandy-walsh) wrote on 2011-06-24:

yeah, it's never actually checked in the code. If you can't do admin operations, the routes are never established so they're short circuited anyway.

Revision history for this message

Thierry Carrez (ttx) wrote on 2011-06-27:

So it looks like a decorator is not really useful, since this is checked only once ? Closing as WONTFIX, please reopen if I understood this wrong.

Changed in nova:
status:	New → Won't Fix

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Bug watches keep track of this bug in other bug trackers.