Plugin interface should perform argument count check
Bug #805905 reported by
Salvatore Orlando
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| neutron |
Fix Released
|
Low
|
Salvatore Orlando | ||
Bug Description
Quantum verifies that the plugin class provides an implementation for every abstract method specified in QuantumPluginBase; however it does not ensure that the argument count is correct; this might lead to errors when plugin methods are invoked.
The attached branch contains a modified version of the __subclasshook__ method which verifies that the implementation provided for each abstract method has the correct number of arguments.
Related branches
lp:~salvatore-orlando/neutron/bug805905
- Somik Behera: Needs Information (netstack-core)
- Diff: 0 lines
| Changed in quantum: | |
| status: | New → Opinion |
| assignee: | nobody → Salvatore Orlando (salvatore-orlando) |
Revision history for this message
| Somik Behera (somikbehera) wrote | #1 |
| Changed in quantum: | |
| status: | Opinion → Confirmed |
Revision history for this message
| Salvatore Orlando (salvatore-orlando) wrote | #2 |
Revision history for this message
| Salvatore Orlando (salvatore-orlando) wrote | #3 |
| Changed in quantum: | |
| status: | Confirmed → In Progress |
| Changed in quantum: | |
| status: | In Progress → Fix Committed |
| Changed in quantum: | |
| importance: | Undecided → Low |
| Changed in quantum: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Sounds valid and changes look good. I would run unit tests and propose for merge and the netstack-core could approve.