Launchpad itself

Don't assume entered package is a binary package

Bug #81014 reported by Björn Tillenius
16
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Gavin Panella

Bug Description

If a source package has the same name as an existing binary package, it's impossible to target bugs to the source package. The package name will be assumed to be the binary package, and will be changed to the binary package's source package.

This has the side effect that you get a confusing error message if you try to reject the mozilla-firefox in bug 37471. (It will say that "This bug has already been reported on firefox (ubuntu).")

Tags: lp-bugs
Revision history for this message
Christian Reis (kiko) wrote :

Could we just change the order in precedence in the lookup? Would that create other problems?

Revision history for this message
Björn Tillenius (bjornt) wrote : Re: [Bug 81014] Re: Don't assume entered package is a binary package

On Mon, Jan 22, 2007 at 05:56:59PM -0000, Christian Reis wrote:
> Could we just change the order in precedence in the lookup? Would that
> create other problems?

I think changing the order of the lookups is enough. I can't think of
any problems that would cause, but I haven't checked all the places that
use guessPackageNames().

Revision history for this message
Christian Reis (kiko) wrote :

On Tue, Jan 23, 2007 at 09:07:22AM -0000, Björn Tillenius wrote:
> On Mon, Jan 22, 2007 at 05:56:59PM -0000, Christian Reis wrote:
> > Could we just change the order in precedence in the lookup? Would that
> > create other problems?
>
> I think changing the order of the lookups is enough. I can't think of
> any problems that would cause, but I haven't checked all the places that
> use guessPackageNames().

I checked:

    launchpad/scripts/bugzilla.py
    launchpad/scripts/debsync.py
    launchpad/xmlrpc/bug.py
    widgets/bugtask.py
    launchpad/database/distribution.py
    launchpad/browser/bugtarget.py

They all look as though matching source package name preferentially
would be fine. There's also the argument that using the source package
lets the user that knows what he's doing choose the right one, with the
binary package name being a fallback, so that ordering is probably
best.

Revision history for this message
Diogo Matsubara (matsubara) wrote :

Confirming as this happened again today in bug 84183. jwendell tried to reject grep-dcrtl (ubuntu) task, but got the confusing error message saying that the bug has already been reported against dcrtl-tools (ubuntu)

Changed in malone:
status: Unconfirmed → Confirmed
Gavin Panella (allenap)
Changed in malone:
assignee: nobody → allenap
status: Confirmed → In Progress
Revision history for this message
Gavin Panella (allenap) wrote :

This is affecting more people, like those at UDS, so priority needs a bump.

Changed in malone:
importance: Undecided → High
Gavin Panella (allenap)
Changed in malone:
status: In Progress → Fix Committed
Revision history for this message
Gavin Panella (allenap) wrote :

This is in RF now, so target to the next milestone.

Revision history for this message
Gavin Panella (allenap) wrote :

Fixed in RF 4311

Gavin Panella (allenap)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.