Launchpad itself

Expanded suggestions on +filebug leak branch icon

Bug #812044 reported by William Grant on 2011-07-17

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Launchpad itself	Fix Released	Critical	Данило Шеган

Bug Description

Since they were ported to the new unified expander setup, expanded suggestions on +filebug leak icons from further down the sprite image. This is presently the branch icon.

The old version used an <img> for the icon, so was not prone to this issue.

Tags:

Related branches

lp:~danilo/launchpad/bug-812044

Merged into lp:launchpad at revision 13466

Henning Eggers (community): Approve on 2011-07-18

Revision history for this message

William Grant (wgrant) wrote on 2011-07-17:

screenshot of the bug Edit (63.3 KiB, image/png)

Revision history for this message

Данило Шеган (danilo) wrote on 2011-07-18:

This is a sprite issue that seems very hard to solve in a generic way: basically, we can extend the spacing between images in a sprite image so we hit it less often, but that's bound to break some time. Interestingly as well, I haven't seen this problem on some very large expanders, so I am at a bit of a loss myself. Asking Huw about it.

Revision history for this message

Huw Wilkins (huwshimi) wrote on 2011-07-18:

The sprite might have to be in its own container, like a span or div. That way the container will have its own bounding box and not bleed sprites (you might have to set some inline-ness of some kind on it too).

Данило Шеган (danilo) on 2011-07-18