Ubuntu Single Sign On Client

Entering invalid email address shows no error in the UI but a popup

Bug #812468 reported by Natalia Bidart
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Single Sign On Client
Fix Released
High
Alejandro J. Cura

Bug Description

I filled in the sign in registration form using "ffff@" as email address, and the UI form did not complain about it. When I submitted the info, the backend failed with this trace:

2011-07-18 18:24:05,213:213.999986649 - ubuntu_sso.account - INFO - register_user: email: 'ffff@' result: {u'status': u'error', u'errors': {u'captcha_solution': [u'This field is required.'], u'email': [u'Enter a valid e-mail address.'], u'__all__': [u'Wrong captcha solution.']}}
2011-07-18 18:24:05,213:213.999986649 - ubuntu_sso.main.windows - DEBUG - SSOLogin: emitting UserRegistrationError with app_name "Ubuntu One" and error <twisted.python.failure.Failure <class 'ubuntu_sso.account.RegistrationError'>>

and the UI showed no error message to me.

Related branches

lp:~alecu/ubuntu-sso-client/everybody-hates-errdicts
Roberto Alsina (community): Approve
Natalia Bidart (community): Approve
Diff: 453 lines (+110/-125)
2 files modified
ubuntu_sso/main/tests/test_windows.py (+104/-113)
ubuntu_sso/main/windows.py (+6/-12)
Natalia Bidart (nataliabidart)
Changed in ubuntuone-windows-installer:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Roberto Alsina (ralsina)
tags: added: u1-zomg-windows
Natalia Bidart (nataliabidart)
summary: - Entering invalid email address shows no error in the UI
+ Entering invalid email address shows no error in the UI but a popup
Revision history for this message
Roberto Alsina (ralsina) wrote :

Tried it and got this error on SSO:

2011-08-29 16:44:05,490:490.999937057 - ubuntu_sso.main.windows - DEBUG - SSOLogin: emitting UserRegistrationError with app_name "Ubuntu One" and error {'errtype': 'RegistrationError', u'email': u'Enter a valid e-mail address.'}
Unhandled error in Deferred:
Traceback (most recent call last):
  File "C:\Python27\lib\site-packages\qtreactor\qt4reactor.py", line 231, in _iterate
    self.runUntilCurrent()
  File "C:\Python27\lib\site-packages\twisted\internet\base.py", line 762, in runUntilCurrent
    f(*a, **kw)
  File "C:\Python27\lib\site-packages\twisted\internet\defer.py", line 388, in errback
    self._startRunCallbacks(fail)
  File "C:\Python27\lib\site-packages\twisted\internet\defer.py", line 455, in _startRunCallbacks
    self._runCallbacks()
--- <exception caught here> ---
  File "C:\Python27\lib\site-packages\twisted\internet\defer.py", line 542, in _runCallbacks
    current.result = callback(current.result, *args, **kw)
  File "c:\Users\ROBERTO\canonical\ubuntu-sso-client\ubuntu_sso\main\windows.py", line 126, in <lambda>
    error_cb(app, except_to_errdict(err.value)), app_name)
  File "c:\Users\ROBERTO\canonical\ubuntu-sso-client\ubuntu_sso\main\windows.py", line 240, in emit_user_registration_error
    except_to_errdict(raised_error.value))
exceptions.AttributeError: 'dict' object has no attribute 'value'

Roberto Alsina (ralsina)
affects: ubuntuone-windows-installer → ubuntu-sso-client
Natalia Bidart (nataliabidart)
Changed in ubuntu-sso-client:
assignee: Roberto Alsina (ralsina) → Natalia Bidart (nataliabidart)
Natalia Bidart (nataliabidart)
Changed in ubuntu-sso-client:
assignee: Natalia Bidart (nataliabidart) → Alejandro J. Cura (alecu)
Ubuntu One Auto Pilot (otto-pilot)
Changed in ubuntu-sso-client:
status: Triaged → Fix Committed
Joshua Hoover (joshuahoover)
tags: added: u1-windows
Natalia Bidart (nataliabidart)
Changed in ubuntu-sso-client:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.