create_makefile.py interferes with correct revision number report
Bug #815814 reported by
Adam Candy
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Fluidity |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
create_makefile.py explicitly excludes a dependency on include/confdefs.h (create_
Related to lp:814839.
Related branches
lp:~wence/fluidity/fixup-version-number
- Adam Candy: Needs Fixing
- Tim Bond (community): Approve
-
Diff: 232 lines (+19/-43)13 files modifiedMakefile.in (+10/-2)
configure (+0/-7)
configure.in (+0/-6)
femtools/Diagnostic_variables.F90 (+1/-0)
femtools/Makefile.dependencies (+2/-2)
include/Usage.h (+1/-0)
include/qg_usage.h (+1/-0)
libadaptivity/configure (+0/-7)
libadaptivity/configure.in (+0/-6)
libvtkfortran/configure (+0/-7)
libvtkfortran/configure.in (+0/-6)
main/Makefile.in (+2/-0)
qg_strat/Makefile.in (+2/-0)
Revision history for this message
| David Ham (david-ham) wrote | #1 |
| Changed in fluidity: | |
| status: | New → Fix Released |
To post a comment you must log in.
I think the actual problem is putting the version number in confdefs.h.
Confdefs.h should really only contain things set by configure. If the version number were put in version.h or similar and the files in main #included that then make makefiles would include the dependency on that file and all would be well.
The reason that make makefiles currently excludes confdefs.h is exactly because confdefs.h is updated on every build. If it were bot excluded, a large number of files would be spuriously rebuit every time. If the version number went into a different file, the exclusion of confdefs could also be removed.