IDifferencesFormSchema.selected_differences vocabulary is too restrictive
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Gavin Panella |
Bug Description
The vocabulary is generated at view initialization time from the
current batch. However, a difference selected on the page may, at form
submission time, no longer be in the batch.
To replicate the problem:
1. Go to +localpackagediffs.
2. Select a package that does not have any syncs outstanding (i.e. the
checkbox on the left is enabled).
3. Expand it and change Ignored from "No" to "These versions".
4. In the filter form at the top, enter the name of tha package,
select "Ignored packages", and submit. The package selected in (2)
should be visible.
5. Expand it and change Ignored from "These versions" to "No".
6. Check the box on the left of the package name.
7. Hit the sync button at the bottom.
8. Observe that the page is submitted but that nothing actually
happens.
Related branches
- Benji York (community): Approve (code)
-
Diff: 348 lines (+228/-20)4 files modifiedlib/lp/registry/browser/distroseries.py (+1/-10)
lib/lp/registry/tests/test_distroseries_vocabularies.py (+138/-7)
lib/lp/registry/vocabularies.py (+77/-3)
lib/lp/registry/vocabularies.zcml (+12/-0)
Changed in launchpad: | |
status: | Triaged → In Progress |
assignee: | nobody → Gavin Panella (allenap) |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Fixed in stable r13579 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 13579>.