OpenStack Compute (nova)

OSAPI: Numerous test cases fail to tear down set FLAGS

Bug #817536 reported by Alex Meade
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
William Wolf

Bug Description

In nova/api/openstack/test_extensions.py, many test cases set FLAGs in setUp but fail to reset them in a tearDown method.

Ex:
 FLAGS.osapi_extensions_path = os.path.join(
            os.path.dirname(__file__), "extensions")

This allows for other test cases in the module to be dependent on a previously run test case, but test cases should be independent. For example, bug 817535

William Wolf (throughnothing)
Changed in nova:
assignee: nobody → William Wolf (throughnothing)
William Wolf (throughnothing)
Changed in nova:
status: New → In Progress
Revision history for this message
Vish Ishaya (vishvananda) wrote : Re: [Bug 817536] Re: OSAPI: Numerous test cases fail to tear down set FLAGS

FYI, I think i fixed all of these in my branch here:
https://code.launchpad.net/~vishvananda/nova/keystone-migration/+merge/68915

Thierry Carrez (ttx)
Changed in nova:
importance: Undecided → Low
Revision history for this message
Mark McLoughlin (markmc) wrote :

Ok, sounds like Vish thinks he had fixed this. Also, I fixed some of this when porting from gflags to optparse and then cfg

Marking as fixed

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.