Remove weak pattern in API
Bug #834008 reported by
Salvatore Orlando
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| neutron |
Fix Released
|
Undecided
|
Salvatore Orlando | ||
| quantum (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
In quantum/
if param_value and param['required']:
this might work quite well if param_value is a string, but can lead to unexpect behaviour for any other kind of data type.
As noted by Dan, it should be replace with a different condition, as follows:
if not param_value is None and param['Required']:
Related branches
lp:~salvatore-orlando/neutron/bug834008
- Tyler Smith: Approve
- dan wendlandt: Approve
-
Diff: 48 lines (+16/-15)1 file modifiedquantum/api/api_common.py (+16/-15)
| Changed in quantum: | |
| assignee: | nobody → Salvatore Orlando (salvatore-orlando) |
| milestone: | none → diablo-rbp |
| Changed in quantum: | |
| status: | New → In Progress |
| Changed in quantum: | |
| status: | In Progress → Fix Committed |
| Changed in quantum: | |
| status: | Fix Committed → Fix Released |
| Changed in quantum (Ubuntu): | |
| status: | New → Fix Released |
To post a comment you must log in.
