[6.0.3] Incorrect Variable naming in product/pricelist.py - price_get_multi
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Odoo Addons (MOVED TO GITHUB) |
Fix Released
|
Low
|
OpenERP R&D Addons Team 2 |
Bug Description
Hi this bit of code, while it doesn't cause a bug is really confusing. Bear in mind this is in an awful function of 98 statements and 54 local variables, so it is hard enough to understand already.
The variable pricelist_
pricelist_ids = self.pool.
next we have plversions_
Now there is plversions_ids, which should more correctly be called pricelist_
if pricelist_ids:
else:
# all pricelists:
'|',
'|',
]
Related branches
- Rucha (Open ERP) (community): Approve
- Rohan Nayani(Open ERP) (community): Needs Resubmitting
- qdp (OpenERP): Pending requested
-
Diff: 75 lines (+17/-25)1 file modifiedproduct/pricelist.py (+17/-25)
Changed in openobject-addons: | |
assignee: | nobody → OpenERP R&D Addons Team 2 (openerp-dev-addons2) |
importance: | Undecided → Low |
status: | New → Confirmed |
Changed in openobject-addons: | |
status: | Confirmed → In Progress |
Hello ,
Thanks for Reporting.
It has been fixed in lp:~openerp-dev/openobject-addons/trunk-bug-847605-ron
revision-id: <email address hidden>
Revision num:4962.
It will be available in trunk soon.