Odoo Addons (MOVED TO GITHUB)

[project_timesheet_contract] should set default cost_based_on, prevents from loading "hr"

Bug #854659 reported by Dimitri John Ledkov (ex-credativ)
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Low
Vishal Parmar(Open ERP)

Bug Description

When installing both hr and project_timesheet_contract on a fresh database, hr module errors out to install hr_data.

The reason being is that "cost_based_on" is a mandatory field on an employee, which is added in "project_timesheet_contract".

Possible solutions:
1) Extend xml data in project_timesheet_contract to add "cost_based_on" for admin user
2) Add default to "product" price for example.

Tested on 6.0 latest revno, but seems to apply to trunk as well.

[2011-09-20 12:55:45,335][project] ERROR:tools.convert.xml_import:Parse error in /home/user/src/openerp/6.0/project/bin/addons/hr/hr_data.xml:19:
<record id="employee" model="hr.employee">
            <field name="name">Administrator</field>
            <field name="user_id" ref="base.user_root"/>
        </record>
Traceback (most recent call last):
  File "/home/user/src/openerp/6.0/project/bin/tools/convert.py", line 865, in parse
    self._tags[rec.tag](self.cr, rec, n)
  File "/home/user/src/openerp/6.0/project/bin/tools/convert.py", line 832, in _tag_record
    id = self.pool.get('ir.model.data')._update(cr, self.uid, rec_model, self.module, res, rec_id or False, not self.isnoupdate(data_node), noupdate=self.isnoupdate(data_node), mode=self.mode, context=rec_context )
  File "/home/user/src/openerp/6.0/project/bin/addons/base/ir/ir_model.py", line 691, in _update
    res_id = model_obj.create(cr, uid, values, context=context)
  File "/home/user/src/openerp/6.0/project/bin/addons/hr_evaluation/hr_evaluation.py", line 134, in create
    id = super(hr_employee, self).create(cr, uid, vals, context=context)
  File "/home/user/src/openerp/6.0/project/bin/osv/orm.py", line 3651, in create
    cr.execute('insert into "'+self._table+'" (id'+upd0+") values ("+str(id_new)+upd1+')', tuple(upd2))
  File "/home/user/src/openerp/6.0/project/bin/sql_db.py", line 78, in wrapper
    return f(self, *args, **kwargs)
  File "/home/user/src/openerp/6.0/project/bin/sql_db.py", line 131, in execute
    res = self._obj.execute(query, params)
IntegrityError: null value in column "cost_based_on" violates not-null constraint

Related branches

lp:openobject-addons/extra-6.0
credativ: Pending requested
Diff: 90905 lines (+70249/-15236)
221 files modified
.bzrignore (+2/-0)
account_asset/i18n/es_AR.po (+529/-0)
account_banking/__init__.py (+0/-33)
account_banking/__terp__.py (+0/-104)
account_banking/account_banking.py (+0/-963)
account_banking/account_banking_demo.xml (+0/-32)
account_banking/account_banking_import_wizard.xml (+0/-15)
account_banking/account_banking_view.xml (+0/-272)
account_banking/account_banking_workflow.xml (+0/-30)
account_banking/i18n/account_banking.pot (+0/-562)
account_banking/i18n/bg.po (+0/-589)
account_banking/i18n/en_US.po (+0/-562)
account_banking/i18n/es.po (+0/-626)
account_banking/i18n/nl.po (+0/-681)
account_banking/i18n/nl_NL.po (+0/-607)
account_banking/i18n/pl.po (+0/-617)
account_banking/i18n/sv.po (+0/-589)
account_banking/parsers/__init__.py (+0/-24)
account_banking/parsers/convert.py (+0/-45)
account_banking/parsers/models.py (+0/-171)
account_banking/record.py (+0/-182)
account_banking/sepa/__init__.py (+0/-23)
account_banking/sepa/bbantoiban.py (+0/-98)
account_banking/sepa/iban.py (+0/-436)
account_banking/sepa/online.py (+0/-186)
account_banking/sepa/postalcode.py (+0/-159)
account_banking/sepa/urlagent.py (+0/-221)
account_banking/struct.py (+0/-55)
account_banking/wizard/__init__.py (+0/-23)
account_banking/wizard/bank_import.py (+0/-593)
account_banking/wizard/banktools.py (+0/-282)
account_banking_nl_clieop/__init__.py (+0/-30)
account_banking_nl_clieop/__terp__.py (+0/-50)
account_banking_nl_clieop/account_banking_export_wizard.xml (+0/-15)
account_banking_nl_clieop/account_banking_nl_clieop.py (+0/-99)
account_banking_nl_clieop/account_banking_nl_clieop.xml (+0/-63)
account_banking_nl_clieop/data/banking_export_clieop.xml (+0/-22)
account_banking_nl_clieop/i18n/account_banking_nl_clieop.pot (+0/-335)
account_banking_nl_clieop/i18n/bg.po (+0/-351)
account_banking_nl_clieop/i18n/en_US.po (+0/-335)
account_banking_nl_clieop/i18n/es.po (+0/-349)
account_banking_nl_clieop/i18n/nl.po (+0/-366)
account_banking_nl_clieop/i18n/nl_NL.po (+0/-341)
account_banking_nl_clieop/wizard/__init__.py (+0/-23)
account_banking_nl_clieop/wizard/clieop.py (+0/-461)
account_banking_nl_clieop/wizard/export_clieop.py (+0/-401)
account_banking_nl_multibank/__init__.py (+0/-29)
account_banking_nl_multibank/__terp__.py (+0/-46)
account_banking_nl_multibank/i18n/account_banking_nl_multibank.pot (+0/-48)
account_banking_nl_multibank/i18n/en_US.po (+0/-48)
account_banking_nl_multibank/i18n/es.po (+0/-64)
account_banking_nl_multibank/i18n/nl.po (+0/-61)
account_banking_nl_multibank/i18n/nl_NL.po (+0/-56)
account_banking_nl_multibank/multibank.py (+0/-184)
account_payment_extension/i18n/account_payment_extension.pot (+2/-2)
account_payment_extension/i18n/bg.po (+4/-4)
account_payment_extension/i18n/ca.po (+15/-6)
account_payment_extension/i18n/es.po (+15/-7)
account_payment_extension/i18n/hu.po (+503/-0)
account_payment_extension/i18n/pt.po (+15/-7)
account_payment_extension/i18n/sv.po (+4/-4)
account_payment_extension/payment.py (+1/-1)
asterisk_click2dial/i18n/hr.po (+434/-0)
base_external_mapping/base_external_mapping.py (+1/-1)
base_language/i18n/it.po (+35/-0)
base_sale_multichannels/i18n/fr.po (+357/-0)
c2c_budget/account.py (+11/-14)
c2c_budget/analytic_account.py (+5/-5)
c2c_budget/c2c_budget.py (+10/-13)
c2c_budget/c2c_budget_item.py (+8/-6)
c2c_budget/c2c_budget_line.py (+24/-20)
c2c_budget/c2c_budget_report_abstraction.py (+2/-2)
c2c_budget/c2c_budget_version.py (+15/-16)
c2c_budget/c2c_budget_wizard_abstraction.py (+7/-7)
fleet_maintenance/__openerp__.py (+1/-1)
fleet_maintenance/crm.py (+3/-3)
fleet_maintenance/crm_sequence.xml (+2/-2)
fleet_maintenance/crm_view.xml (+33/-41)
fleet_maintenance/invoice.py (+1/-1)
fleet_maintenance/sale.py (+1/-1)
fleet_maintenance/stock.py (+3/-3)
fleet_maintenance/stock_view.xml (+0/-1)
hotel/__openerp__.py (+56/-0)
hotel/__terp__.py (+0/-56)
hotel/hotel.py (+45/-17)
hotel/hotel_view.xml (+44/-31)
hotel/hotel_wizard.xml (+0/-20)
hotel/wizard/hotel_wizard.py (+30/-52)
hotel/wizard/hotel_wizard.xml (+36/-0)
hotel_housekeeping/__openerp__.py (+50/-0)
hotel_housekeeping/__terp__.py (+0/-52)
hotel_housekeeping/hotel_housekeeping.py (+25/-38)
hotel_housekeeping/report/housekeeping_report.py (+1/-2)
hotel_housekeeping/wizard/housekeeping_wizard.py (+0/-10)
hr_holidays_request/__openerp__.py (+1/-1)
hr_holidays_request/hr_holidays_request.py (+1/-0)
hr_holidays_request/hr_workflow.xml (+16/-28)
hr_holidays_request/security/hr_holidays_request_security.xml (+10/-0)
hr_holidays_request/security/ir.model.access.csv (+4/-4)
hr_payroll/i18n/ar.po (+1500/-0)
hr_payroll/i18n/cs.po (+1518/-0)
hr_payroll/i18n/pt.po (+18/-18)
hr_payroll/i18n/ro.po (+1500/-0)
hr_skill/__openerp__.py (+2/-1)
hr_skill/hr_skill.py (+2/-4)
hr_skill/hrskill.py (+13/-16)
ingram/__init__.py (+27/-0)
ingram/__openerp__.py (+58/-0)
ingram/csv_file.py (+121/-0)
ingram/csv_file_view.xml (+19/-0)
ingram/i18n/ca.po (+426/-0)
ingram/i18n/es.po (+426/-0)
ingram/i18n/ingram.pot (+415/-0)
ingram/ingram.py (+355/-0)
ingram/ingram_view.xml (+77/-0)
ingram/product.py (+48/-0)
ingram/product_view.xml (+30/-0)
ingram/security/ir.model.access.csv (+2/-0)
ingram/settings/csv_mapping.xml (+169/-0)
ingram/settings/ingram_data.xml (+32/-0)
ingram/temp/.~lock.dest.csv# (+1/-0)
ingram/temp/CATSCAT.TXT (+548/-0)
ingram/temp/PRICE09.TXT (+43321/-0)
l10n_fr_rib/__init__.py (+25/-0)
l10n_fr_rib/__openerp__.py (+51/-0)
l10n_fr_rib/bank.py (+118/-0)
l10n_fr_rib/bank_data.xml (+44/-0)
l10n_fr_rib/bank_view.xml (+44/-0)
l10n_fr_rib/i18n/fr.po (+132/-0)
l10n_fr_rib/i18n/l10n_fr_rib.pot (+112/-0)
label/__openerp__.py (+1/-0)
label/i18n/hu.po (+0/-415)
label/i18n/th.po (+415/-0)
label/partner_wizard.xml (+8/-1)
label/report/report_partner_labels.py (+61/-36)
label/report_label_data.xml (+14/-0)
label/wizard/wizard_partner_labels.py (+67/-123)
label/wizard/wizard_partner_labels_view.xml (+37/-0)
lunch/i18n/ar.po (+360/-0)
lunch/i18n/hr.po (+349/-0)
lunch/i18n/ro.po (+360/-0)
marketing/i18n/ar.po (+434/-0)
marketing/i18n/hr.po (+434/-0)
mrp_operations_extension/__init__.py (+24/-0)
mrp_operations_extension/__openerp__.py (+41/-0)
mrp_operations_extension/mrp_operations_extension.py (+39/-0)
nan_product_pack/pack.py (+4/-0)
paydays/i18n/it.po (+50/-0)
point_of_sale/i18n/nl.po (+178/-229)
product_gs1_128/__init__.py (+22/-0)
product_gs1_128/__openerp__.py (+52/-0)
product_gs1_128/data/product.gs1_128.csv (+131/-0)
product_gs1_128/i18n/fr.po (+850/-0)
product_gs1_128/product_gs1_128.py (+182/-0)
product_gs1_128/product_gs1_128_view.xml (+46/-0)
product_gs1_128/res_users.py (+34/-0)
product_gs1_128/res_users_view.xml (+19/-0)
product_gs1_128/security/ir.model.access.csv (+2/-0)
product_icecat/i18n/ca.po (+18/-15)
product_icecat/i18n/es.po (+14/-11)
product_icecat/icecat/0884343043951.xml (+969/-0)
product_icecat/icecat/4026203829923.xml (+456/-0)
product_icecat/icecat/4905524709148.xml (+792/-0)
product_icecat/icecat/4905524713244.xml (+900/-0)
product_icecat/icecat/4905524716207.xml (+1351/-0)
product_icecat/icecat/4905524719888.xml (+1441/-0)
product_icecat/icecat/4905524720464.xml (+1380/-0)
product_icecat/icecat/8710103446002.xml (+533/-0)
product_links/__openerp__.py (+2/-1)
product_links/security/ir.model.access.csv (+3/-0)
product_m2mcategories/product_view.xml (+13/-1)
product_minimal_stock_rule/__init__.py (+1/-0)
product_minimal_stock_rule/__openerp__.py (+43/-0)
product_minimal_stock_rule/product.py (+55/-0)
product_minimal_stock_rule/product_minimal_stock_rule_view.xml (+17/-0)
product_minimal_stock_rule/test/test_rule.yml (+20/-0)
product_variant_configurator/configurator_view.xml (+50/-55)
product_variant_configurator/configurator_wizard.py (+13/-9)
product_variant_configurator/product.py (+4/-3)
product_variant_configurator/sale.py (+3/-4)
product_variant_configurator/sale_view.xml (+46/-50)
product_variant_configurator/security/ir.model.access.csv (+3/-3)
product_variant_multi/__openerp__.py (+5/-1)
product_variant_multi/i18n/ca.po (+381/-118)
product_variant_multi/i18n/es.po (+381/-118)
product_variant_multi/i18n/fr.po (+299/-102)
product_variant_multi/i18n/hu.po (+296/-102)
product_variant_multi/i18n/pl.po (+316/-104)
product_variant_multi/i18n/product_variant_multi.pot (+289/-102)
product_variant_multi/i18n/pt.po (+317/-104)
product_variant_multi/i18n/sv.po (+283/-98)
product_variant_multi/product_variant.py (+72/-42)
product_variant_multi/product_view.xml (+83/-57)
product_variant_multi_advanced/__openerp__.py (+1/-1)
product_variant_multi_advanced/product.py (+4/-3)
product_variant_multi_advanced/product.xml (+0/-1)
project_task_delegate_state/__init__.py (+1/-0)
project_task_delegate_state/__openerp__.py (+41/-0)
project_task_delegate_state/project.py (+33/-0)
project_task_delegate_state/tests/delegate.yml (+52/-0)
sale_delivery/i18n/nl.po (+124/-0)
sale_margin/i18n/ar.po (+358/-0)
sale_margin/i18n/hr.po (+369/-0)
sale_pricelist_recalculation/wizard/wizard_sale_pricelist_recalculation.py (+2/-2)
sale_pricelist_recalculation/wizard/wizard_sale_pricelist_recalculation.xml (+1/-9)
sale_product_multistep_configurator/sale.py (+1/-3)
sale_product_multistep_configurator/sale_product_multistep_configurator.py (+6/-2)
sale_product_multistep_configurator/sale_product_multistep_configurator.xml (+59/-59)
sale_product_multistep_configurator/sale_view.xml (+68/-68)
sale_product_multistep_configurator/security/ir.model.access.csv (+1/-1)
server_migration/__init__.py (+20/-12)
server_migration/__openerp__.py (+20/-12)
server_migration/migration.py (+20/-12)
server_migration/wizard/__init__.py (+20/-12)
server_migration/wizard/configuration.py (+20/-12)
server_migration/wizard/load_config.py (+20/-12)
server_migration/wizard/wizard_import_data.py (+20/-12)
server_migration/wizard/wizard_model_compare.py (+20/-12)
server_migration/wizard/wizard_server_compare.py (+20/-12)
smtpclient/security/ir.model.access.csv (+1/-0)
stock_planning/i18n/nl.po (+368/-0)
Jordi Esteve: Pending requested
Diff: 2033448 lines
Revision history for this message
Dimitri John Ledkov (ex-credativ) (dle-credativ) wrote :

Further investigating, it seems like the field cost_based_on cannot be mandatory because neither contract nor product are mandatory fields....

Revision history for this message
Dimitri John Ledkov (ex-credativ) (dle-credativ) wrote :

I guess it's best to use "hr_contract_timesheet" with "project_timesheet" both are certified modules and give similar functionality.

Other projects with project_timsheet_contract are:
* missing translate import while using "_"
* doesn't define base product or contract for the default user/employee admin, hence failing install.

Vishal Parmar(Open ERP) (vpa-openerp)
Changed in openobject-addons:
assignee: nobody → Vishal Parmar(Open ERP) (vpa-openerp)
importance: Undecided → Low
status: New → Confirmed
status: Confirmed → In Progress
Revision history for this message
Vishal Parmar(Open ERP) (vpa-openerp) wrote :

Hello,

Thanks for reporting,

I have checked this issue, The related problem is only reproducible in stable 6 not in trunk version.

This has been fixed with the following revision :

5532 <email address hidden>

Thanks.

Changed in openobject-addons:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.