It would be nice if checkbox would tell me exactly what requirement was not met for a test that was not run.
Bug #855852 reported by
Jeff Lane
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Checkbox |
Fix Released
|
Low
|
Brendan Donegan | ||
Bug Description
A test can have multiple requirements, and a given test run could have multiple tests that aren't run due to requirements not being satisfied.
It would be nice if, instead of a generic and unhelpful "Job requirements not met" checkbox would actually list WHICH requirement was not met.
A good example of this is the suspend/
requires:
device.category == 'AUDIO'
package.name == 'sox'
package.name == 'alsa-base'
and fails to run in Oneiric. Now I know the reason is that sox isn't installed. However, the user wouldn't know that. So having the test report actually say something like:
Requirement 'package.name == sox' not met
And please ignore the test itself, I only include that as an easy example.
Related branches
lp:~brendan-donegan/checkbox/which_requirements
- Daniel Manrique (community): Approve
-
Diff: 48 lines (+17/-1)2 files modifieddebian/changelog (+3/-0)
plugins/resource_info.py (+14/-1)
lp:~roadmr/ubuntu/oneiric/checkbox/0.13
- Ubuntu Sponsors: Pending requested
-
Diff: 18858 lines (+9936/-3266)93 files modifiedcheckbox/application.py (+5/-5)
checkbox/contrib/persist.py (+5/-4)
checkbox/dispatcher.py (+201/-0)
checkbox/lib/bit.py (+5/-4)
checkbox/lib/config.py (+15/-2)
checkbox/lib/conversion.py (+131/-42)
checkbox/lib/dmi.py (+169/-18)
checkbox/lib/safe.py (+5/-0)
checkbox/lib/template.py (+1/-1)
checkbox/message.py (+4/-3)
checkbox/parsers/cpuinfo.py (+30/-41)
checkbox/parsers/cputable (+40/-0)
checkbox/parsers/cputable.py (+42/-0)
checkbox/parsers/deferred.py (+27/-0)
checkbox/parsers/dmidecode.py (+123/-0)
checkbox/parsers/meminfo.py (+46/-0)
checkbox/parsers/submission.py (+474/-383)
checkbox/parsers/udevadm.py (+178/-317)
checkbox_cli/cli_interface.py (+9/-1)
checkbox_gtk/gtk_interface.py (+4/-4)
data/whitelists/default.whitelist (+1/-0)
debian/changelog (+59/-0)
debian/po/ro.po (+118/-0)
examples/checkbox.ini (+1/-1)
gtk/checkbox-gtk.ui (+37/-37)
jobs/apport.txt.in (+0/-5)
jobs/audio.txt.in (+44/-24)
jobs/autotest.txt.in (+4/-2)
jobs/bluetooth.txt.in (+64/-52)
jobs/camera.txt.in (+19/-12)
jobs/codecs.txt.in (+16/-38)
jobs/cpu.txt.in (+3/-3)
jobs/daemons.txt.in (+11/-11)
jobs/disk.txt.in (+6/-5)
jobs/evolution.txt.in (+0/-26)
jobs/fingerprint.txt.in (+24/-20)
jobs/firewire.txt.in (+9/-8)
jobs/gcalctool.txt.in (+0/-52)
jobs/gedit.txt.in (+0/-22)
jobs/gnome-terminal.txt.in (+0/-12)
jobs/graphics.txt.in (+63/-51)
jobs/hibernate.txt.in (+9/-7)
jobs/info.txt.in (+47/-27)
jobs/input.txt.in (+15/-7)
jobs/install.txt.in (+1/-1)
jobs/keys.txt.in (+58/-45)
jobs/local.txt.in (+41/-6)
jobs/ltp.txt.in (+3/-2)
jobs/mago.txt.in (+4/-2)
jobs/mediacard.txt.in (+106/-84)
jobs/memory.txt.in (+8/-5)
jobs/miscellanea.txt.in (+19/-8)
jobs/monitor.txt.in (+43/-24)
jobs/networking.txt.in (+31/-32)
jobs/optical.txt.in (+56/-42)
jobs/panel_clock_test.txt.in (+18/-15)
jobs/panel_reboot.txt.in (+8/-6)
jobs/pcmcia-pcix.txt.in (+6/-3)
jobs/peripheral.txt.in (+27/-22)
jobs/phoronix.txt.in (+4/-2)
jobs/power-management.txt.in (+32/-18)
jobs/qa_regression.txt.in (+4/-2)
jobs/resource.txt.in (+15/-0)
jobs/screenshot.txt.in (+0/-13)
jobs/server-services.txt.in (+12/-12)
jobs/stress.txt.in (+18/-10)
jobs/suspend.txt.in (+52/-31)
jobs/usb.txt.in (+55/-36)
jobs/user_apps.txt.in (+337/-110)
jobs/wireless.txt.in (+9/-9)
plugins/apport_prompt.py (+1/-1)
plugins/launchpad_report.py (+6/-4)
plugins/persist_info.py (+2/-1)
plugins/resource_info.py (+14/-1)
plugins/system_info.py (+2/-2)
po/POTFILES.in (+0/-6)
po/ca@valencia.po (+2897/-0)
po/el.po (+229/-293)
po/en_GB.po (+240/-240)
po/gd.po (+2606/-0)
po/ja.po (+297/-335)
po/lt.po (+294/-357)
po/tr.po (+217/-177)
scripts/connect_wireless (+1/-1)
scripts/cpuinfo_resource (+13/-17)
scripts/dmi_resource (+55/-0)
scripts/hal_resource (+0/-5)
scripts/meminfo_resource (+15/-27)
scripts/package_resource (+6/-0)
scripts/udev_resource (+2/-2)
scripts/usb_test (+5/-3)
setup.cfg (+1/-7)
setup.py (+2/-0)
| Changed in checkbox: | |
| importance: | Undecided → Low |
Revision history for this message
| Brendan Donegan (brendan-donegan) wrote | #1 |
| Changed in checkbox: | |
| status: | New → Confirmed |
| status: | Confirmed → Triaged |
| assignee: | nobody → Brendan Donegan (brendan-donegan) |
| assignee: | Brendan Donegan (brendan-donegan) → nobody |
Revision history for this message
| Brendan Donegan (brendan-donegan) wrote | #2 |
| Changed in checkbox: | |
| assignee: | nobody → Brendan Donegan (brendan-donegan) |
| status: | Triaged → In Progress |
Revision history for this message
| Brendan Donegan (brendan-donegan) wrote | #3 |
Revision history for this message
| Brendan Donegan (brendan-donegan) wrote | #4 |
| Changed in checkbox: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Ara Pulido (ara) wrote | #5 |
| Changed in checkbox: | |
| milestone: | none → 0.13 |
| status: | Fix Committed → Triaged |
Revision history for this message
| Brendan Donegan (brendan-donegan) wrote | #6 |
| Changed in checkbox: | |
| status: | Triaged → In Progress |
| Changed in checkbox: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
Agree on the Low importance as it's only really useful for debugging. I can't see how this should be difficult since Checkbox is obviously going to be aware of which requirement wasn't met as it checks it.