TPAC: Record details: unhide details, use more semantic markup

Bug #857572 reported by Dan Scott
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

The current TPAC skin uses a lot of hidden content and lots of tables inside of tables for layout, with a lack of identification of some important elements such as the title. Some discussion about this is at http://list.georgialibraries.org/pipermail/open-ils-dev/2011-September/007564.html

I pushed a branch to the working repo at user/dbs/tpac_semantic_amazon_record_details and think it is worthy of merging to master - although I hope to be able to do more (such as unhide serials summaries, add schema.org microdata, etc) in the future.

Tags: pullrequest
Dan Scott (denials)
tags: added: pullrequest
Changed in evergreen:
importance: Undecided → Wishlist
Revision history for this message
Dan Scott (denials) wrote :

Jason Stephenson noted that the branch I posted now had conflicts (yay for letting branches linger) so I posted a rebased branch at:

  * user/dbs/tpac_semantic_rebase_2011_09_23 in the working repo

Revision history for this message
Dan Scott (denials) wrote :

Pushed an update to the branch to resolve further merge conflicts.

Revision history for this message
Jason Stephenson (jstephenson) wrote :

When I merge into a fresh checkout of master at 2011-09-30 13:38-0400, I get the following:

jason@jason:~/Src/Evergreen$ git merge working/user/dbs/tpac_semantic_amazon_record_details
Auto-merging Open-ILS/src/templates/opac/parts/searchbar.tt2
CONFLICT (content): Merge conflict in Open-ILS/src/templates/opac/parts/searchbar.tt2
Automatic merge failed; fix conflicts and then commit the result.

Looks like there is now a conflict with commit f3bed157bc524e5c88e07407fc56b1bfb8998406

Revision history for this message
Dan Scott (denials) wrote :

Thanks, Jason. I should note that my update from 2011-09-23 pointed to a new branch, working/user/dbs/tpac_semantic_rebase_2011_09_23, because I didn't want to force-push an update to the original branch given that at least one other person was trying to build enhancements on top of the original branch.

However, with that branch I still get conflicts due to recent changes in searchbar.tt2 and style.css. So I'll try to resolve the conflicts and push an updated branch. Hang on...

Revision history for this message
Dan Scott (denials) wrote :

Pushed a new branch to the working repo: user/dbs/tpac_semantic_rebase_2011_09_30

This branch drops the MFHD commits that were already merged to master and resolves two conflicts that occurred with master due to commits since I last resolved conflicts on 2011-09-23.

Revision history for this message
Jason Stephenson (jstephenson) wrote :

The user/dbs/tpac_semantic_rebase_2011_09_30 branch merges cleanly for me.

Thanks, Dan!

Revision history for this message
Thomas Berezansky (tsbere) wrote :

Lets kill this rebase dance.

Pushed to master!

Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
milestone: none → 2.2.0
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.