Fixes in charm bundling for Go are necessary
Bug #859151 reported by
Gustavo Niemeyer
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| pyjuju |
Fix Released
|
Undecided
|
Gustavo Niemeyer | ||
Bug Description
A few fixes in the charm bundling for Go are necessary:
- It must ignore hidden files as in the Python version.
- Empty directories should be handled properly too.
- It must also use the new filepath.Walk interface rather than an internal one.
Related branches
lp:~niemeyer/pyjuju/go-charm-bits
- Roger Peppe (community): Approve
- William Reade (community): Approve
-
Diff: 326 lines (+80/-132)7 files modifiedcharm/Makefile (+0/-1)
charm/bundle.go (+9/-0)
charm/dir.go (+49/-49)
charm/dir_test.go (+19/-2)
charm/rel_test.go (+1/-2)
charm/testrepo/dummy/hooks/install (+2/-0)
charm/walk.go (+0/-78)
| Changed in juju: | |
| assignee: | nobody → Gustavo Niemeyer (niemeyer) |
| milestone: | none → eureka |
| status: | New → In Progress |
| summary: |
- Improvements and fixes in charm directory packing + Fixes in charm directory packing are necessary |
| description: | updated |
| summary: |
- Fixes in charm directory packing are necessary + Fixes in charm directory packing for Go are necessary |
| summary: |
- Fixes in charm directory packing for Go are necessary + Fixes in charm bundling for Go are necessary |
| description: | updated |
| Changed in juju: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
