Dynamic loading comments load on top of page content

Bug #867529 reported by Martin Albisetti
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Curtis Hovey

Bug Description

When loading comments, it seems to load on top of content on the page. This screnshot shows the footer being overlayed, but I saw the comments being loading on top of comments as well.

Related branches

Revision history for this message
Martin Albisetti (beuno) wrote :
Gary Poster (gary)
Changed in launchpad:
status: New → Triaged
importance: Undecided → Critical
tags: added: regression
tags: added: story-batched-comment-loading
Revision history for this message
Robert Collins (lifeless) wrote :

This is a beta feature; issues with it are not criticals.

Changed in launchpad:
importance: Critical → High
Graham Binns (gmb)
Changed in launchpad:
assignee: nobody → Graham Binns (gmb)
Graham Binns (gmb)
Changed in launchpad:
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
William Grant (wgrant) wrote :

It still loads over the content, but eventually settles down. It's possible it's just the layout engine reacting badly to the insanity.

tags: added: qa-untestable
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
Revision history for this message
Martin Albisetti (beuno) wrote :

I'm a bit disappointed the bug got closed with comments still loading on top of content, even if it just temporary :)
It makes the whole process feel clunky and generally indicates the added nodes aren't properly contained, opening up the door for breakage in future CSS/HTML changes.

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 867529] Re: Dynamic loading comments load on top of page content

Whats a good way to debug that?

Revision history for this message
Martin Albisetti (beuno) wrote :

The best way to debug it is using firebug.
I can't easily debug the javascript without getting the whole launchpad tree, but I'd bet this due to the height not being pre-calculated properly, YUI has some conveniences for this in its anim module.

Going a bit on a tangent here, you should never really have this many (html) nodes on a page. The CPU and ram usage during the loading and later scrolling of this page is a testament to that (also, the returned HTML is super noisy adding even more nodes like a table for each row).
In order to load huge amount of data on a page, what you need to do is have a fixed set of nodes that get re-written as you scroll (this is a big change from what you have designed right now, where a huge chunk of HTML is returned and appended).
We're working on something like this right now in U1 using YUI3, so if there's interest in pursuing this, I'd be happy set up a call to spread some of this knowledge around.

Revision history for this message
Martin Albisetti (beuno) wrote :

Here's a nice jquery example of the above concept in action: http://jsfiddle.net/SDa2B/

Revision history for this message
Graham Binns (gmb) wrote :

It should be noted that the bug being closed doesn't actually mean that I considered the bug fixed. I had a massive amount of trouble reproducing it with anything like the the reliability that Martin has managed. I didn't even see the bug at all when using Chrom(e|ium).

If this is going to be tackled properly we need to work at a deeper level than fixing the JS or indeed the returned HTML. There are lots of issues with the underlying model of bug comments (which have Special Things done to them at the View level), mostly to do with legacy behaviour but also connected to the activity log interleaving code. I shan't enumerate the problems that led me to use the rather kludgy solution that I did for dynamic comment loading, but I think we should go and fix that and only then come back to make the JS work better, otherwise we're just polishing the proverbially unpolishable.

Revision history for this message
Graham Binns (gmb) wrote :

I'm re-marking this triaged and removing myself as an assignee; the bug is definitely there, but it's not something we can tackle properly right now.

Changed in launchpad:
status: Fix Released → Triaged
assignee: Graham Binns (gmb) → nobody
Revision history for this message
Robert Collins (lifeless) wrote :

It has been released with a regression, that makes this critical now.

Changed in launchpad:
importance: High → Critical
Curtis Hovey (sinzui)
tags: added: javascript
tags: added: firefox
Curtis Hovey (sinzui)
tags: added: css
Revision history for this message
Curtis Hovey (sinzui) wrote :

This was an issue in the old Firefox rendering engine. I cannot reproduce this using the current browser.

Changed in launchpad:
assignee: nobody → Curtis Hovey (sinzui)
status: Triaged → Invalid
status: Invalid → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.