remove LockableFiles
Bug #88848 reported by
Martin Pool
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Bazaar |
Confirmed
|
Medium
|
Unassigned | ||
Bug Description
There is a LockableFiles instance in most branch, repository and workingtree objects called _control_files. It's not particularly helping at this point and could be removed. Instead just have the objects talk directly to their transport and lock.
Related branches
Revision history for this message
| Aaron Bentley (abentley) wrote | #1 |
| Changed in bzr: | |
| importance: | Undecided → Medium |
| status: | New → Confirmed |
| Changed in bzr: | |
| status: | Confirmed → In Progress |
| assignee: | nobody → Martin Pool (mbp) |
| Changed in bzr: | |
| importance: | Medium → Low |
| Changed in bzr: | |
| status: | In Progress → Confirmed |
| importance: | Low → Medium |
| assignee: | Martin Pool (mbp) → nobody |
| tags: | added: check-for-breezy |
| tags: | removed: check-for-breezy |
To post a comment you must log in.
LockableFiles itself may be an unnecessary abstraction, but at minimum, we ought to keep the lock itself abstract.
I think locking mechanisms should be the purview of the control directory format. So the hpss locking can be different from the http locking, and if we need to create a new lock mechanism at some point, we only need a new BzrMetaFormat-- we don't need new tree, branch and repository formats.
So I think the BzrDirFormat should control the locking mechanism used.