Translations import queue pages no longer show statuses

Bug #894690 reported by Jeroen T. Vermeulen
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Jeroen T. Vermeulen
Ubuntu Translations
Fix Released
Critical
Unassigned

Bug Description

The translations import queue pages no longer show the status of each import queue entry.

Example page: https://translations.launchpad.net/ubuntu/precise/+imports

We expect admins, Ubuntu coordinators, but also regular users to act on the statuses displayed on that page so it's essential that they be visible.

Related branches

David Planella (dpm)
Changed in ubuntu-translations:
status: New → Triaged
importance: Undecided → Critical
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Apparent cause: Huw replaced the ugly style="display:none" in lib/lp/translations/templates/translation-import-queue-macros.pt with a nicer class="hidden".

But the code in lib/lp/translations/javascript/importqueue.js, in function init_status_choice, tries to make the status visible by doing:

    content_box.setStyle('display', '');

That won't work when the style isn't even set.

This is annoyingly hard to test for: you'd need a test with full-on TAL rendering to catch it. Which is way overkill, really.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
Changed in launchpad:
assignee: nobody → Jeroen T. Vermeulen (jtv)
tags: added: qa-needstesting
Changed in launchpad:
status: Triaged → Fix Committed
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
Gabor Kelemen (kelemeng)
Changed in ubuntu-translations:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.