Odoo Addons (MOVED TO GITHUB)

hr_attendance web client active_ids

Bug #902391 reported by Nikola Stojanoski
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Low
OpenERP R&D Addons Team 3

Bug Description

Using the latest trunk data I'm having this problem:

openerp-web - 1669
openobject-server - 3863
openobject-addons - 5913

When i select a user and click on Attendance by month report active_ids are passed OK to the wizard, but when i click Print on the wizard active_ids value is changed with the value of the form id.

This is a only happening in web client. I don't think it's general web client bug because if i try to get a report for Products everything is OK.

To reproduce problem go to HR, open Employees, check one of the employees, click on Attendance by Month report and click Print.
If you have more employees from demo you will get report for different user each time, but if you have only Administrator you will get report for Administrator the first time and then error because the form id will be 2, 3, 4, ... etc and there is no employee with that id.

Regards,
Nikola

Related branches

lp:~openerp-dev/openobject-addons/trunk-bug-902391-hpa
OpenERP Core Team: Pending requested
Diff: 51 lines (+5/-4)
2 files modified
hr_attendance/report/attendance_by_month.py (+4/-4)
hr_attendance/wizard/hr_attendance_bymonth.py (+1/-0)
Revision history for this message
Nikola Stojanoski (nstojanoski) wrote :

I've fixed this problem, now i can get correct Employees for the report using the web client.

Please apply this patch.

Regards,
Nikola

Changed in openobject-addons:
status: New → Fix Committed
Revision history for this message
Jignesh Rathod(OpenERP) (jir-openerp) wrote :

Hello Nikola,

I have checked this issue with GTK as well as in new web client and it
working as accepted I have selected a Administrator for Attendance by month report
and it will return me a correct active_ id . I have also apply your patch but result is same.
so would you please elaborate more regarding this issue.

Thanks and waiting for replay.

Changed in openobject-addons:
status: Fix Committed → Incomplete
Revision history for this message
Nikola Stojanoski (nstojanoski) wrote :

Look at the video.

1. When i select Administrator the active_id / active_ids is 1 as the id of Administrator.
2. When i click on Attendance by Month the active_id/active_ids is 1 and form id is 44
3. When i click Print active_id/active_ids is changed to the value of the form id (in this case 44)

Maybe on your test that was your first form and form id 1 has matched Administrator id 1. Try clicking Print and the form id will increase and you will get the error i'm getting.

Maybe context should be somehow passed to the form and the form should pass that context but in this process active_ids are changed to the value of the form id. Maybe my solution is not very good, but it solves this problem

Regards,
Nikola

Revision history for this message
Jignesh Rathod(OpenERP) (jir-openerp) wrote :
Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
importance: Undecided → Low
status: Incomplete → Confirmed
Revision history for this message
Jignesh Rathod(OpenERP) (jir-openerp) wrote :

Hello Nikola ,

I have applied this path and its working fine .
I have attached a video for more reference.

Thanks for reporting.

Hemendra Paregi (OpenERP) (hpa-openerp)
Changed in openobject-addons:
status: Confirmed → In Progress
Hemendra Paregi (OpenERP) (hpa-openerp)
Changed in openobject-addons:
status: In Progress → Fix Committed
status: Fix Committed → Confirmed
Hemendra Paregi (OpenERP) (hpa-openerp)
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Hemendra Paregi (OpenERP) (hpa-openerp) wrote :

Hello

       I have applied your patch and its working fine for the attandance_by_month.

      Its fixed in https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-902391-hpa/+merge/85994
      Revision ID:<email address hidden>
      Revision no: 5989

      It will be merged soon with Addons.

Thanks,
Hemendra

Changed in openobject-addons:
status: In Progress → Fix Committed
Fabien (Open ERP) (fp-tinyerp)
Changed in openobject-addons:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.