gate-keystone-merge broken for stable/diablo

Bug #917759 reported by Andrew Hutchings
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Core Infrastructure
Invalid
Critical
Unassigned

Bug Description

See https://review.openstack.org/2840

It has triggered merge job:
https://jenkins.openstack.org/job/gate-keystone-merge/628/
and I re-triggered at:
https://jenkins.openstack.org/job/gate-keystone-merge/633/

According to the console output these jobs succeed but there is no merged trigger sent back to Gerrit and neither the Gerrit's git clone or github seem to have the merge for stable/diablo.

Revision history for this message
Andrew Hutchings (linuxjedi) wrote :

Note that I think this is because it is done as a fast-forward merge which doesn't generate a merge commit. We should probably use --no-ff

Revision history for this message
Andrew Hutchings (linuxjedi) wrote :

Ignore that last comment, didn't fix it :(

Revision history for this message
Andrew Hutchings (linuxjedi) wrote :

Gah! Was due to a +2 missing in the code-review. We should probably have something to stop a +1 in Approve without a code-review but that is for another bug report

Changed in openstack-ci:
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.