OpenStack Core Infrastructure

Gerrit should error if an Approval is attempted without a +2 in code review

Bug #917844 reported by Andrew Hutchings
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Core Infrastructure
Won't Fix
Low
Unassigned

Bug Description

If an Approval is ticked without a +2 in code review the automatic merge job will silently fail when doing the Jenkins->Gerrit trigger. Gerrit should probably give an error at the Approval button stage stating that this will happen.

Revision history for this message
James E. Blair (corvus) wrote :

Gerrit's new prolog capability may be helpful here.

Changed in openstack-ci:
importance: Wishlist → Low
status: New → Triaged
Revision history for this message
James E. Blair (corvus) wrote :

Zuul will not enqueue a change with an approval but no code review, so I don't think this is an operational problem (though it may still be a nice UI improvement).

Changed in openstack-ci:
status: Triaged → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.