Qt UI: must call the backend passing reply_handler and error_handler
Bug #931452 reported by
Natalia Bidart
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| Ubuntu Single Sign On Client | Status tracked in Trunk | |||||
| Stable-3-0 |
Fix Released
|
Undecided
|
Unassigned | |||
| Trunk |
Fix Released
|
High
|
Diego Sarmentero | |||
Bug Description
When calling the backend, reply_handler and error_handler args must be passed so when using DBus on Linux we ensure that the calls return immediately.
To do this, you can mimic what's done in the Gtk UI. Please be sure to have a NO_OP as reply_handler, and an actual error handler for the error_handler so we don't mask DBus errors when making the call.
Related branches
lp:~diegosarmentero/ubuntu-sso-client/931452
- Natalia Bidart (community): Approve
- Brian Curtin (community): Approve
- Manuel de la Peña (community): Approve
-
Diff: 752 lines (+219/-95)15 files modifiedubuntu_sso/qt/current_user_sign_in_page.py (+5/-1)
ubuntu_sso/qt/email_verification_page.py (+6/-1)
ubuntu_sso/qt/forgotten_password_page.py (+11/-3)
ubuntu_sso/qt/gui.py (+7/-0)
ubuntu_sso/qt/reset_password_page.py (+8/-1)
ubuntu_sso/qt/setup_account_page.py (+13/-4)
ubuntu_sso/qt/tests/__init__.py (+22/-2)
ubuntu_sso/qt/tests/test_current_user_sign_in_page.py (+26/-22)
ubuntu_sso/qt/tests/test_email_verification.py (+9/-11)
ubuntu_sso/qt/tests/test_forgotten_password.py (+16/-9)
ubuntu_sso/qt/tests/test_network_detection.py (+2/-4)
ubuntu_sso/qt/tests/test_reset_password.py (+77/-31)
ubuntu_sso/qt/tests/test_setup_account.py (+13/-2)
ubuntu_sso/qt/tests/test_sign_in_page.py (+2/-2)
ubuntu_sso/qt/tests/test_ubuntu_sso_wizard.py (+2/-2)
lp:~nataliabidart/ubuntu-sso-client/stable-3-0-update-2.99.5
- Roberto Alsina (community): Approve
-
Diff: 2716 lines (+888/-321)46 files modifieddata/qt/resources.qrc (+10/-0)
data/qt/setup_account.ui (+35/-2)
data/qt/stylesheet.qss (+119/-0)
run-tests (+1/-1)
setup.py (+0/-39)
ubuntu_sso/credentials.py (+3/-1)
ubuntu_sso/gtk/gui.py (+14/-16)
ubuntu_sso/gtk/tests/test_gui.py (+57/-53)
ubuntu_sso/keyring/tests/test_linux.py (+2/-3)
ubuntu_sso/main/__init__.py (+1/-1)
ubuntu_sso/main/linux.py (+2/-3)
ubuntu_sso/main/qt.py (+23/-3)
ubuntu_sso/main/tests/test_common.py (+15/-22)
ubuntu_sso/main/tests/test_qt.py (+69/-0)
ubuntu_sso/qt/__init__.py (+0/-10)
ubuntu_sso/qt/common.py (+1/-0)
ubuntu_sso/qt/current_user_sign_in_page.py (+18/-8)
ubuntu_sso/qt/email_verification_page.py (+6/-1)
ubuntu_sso/qt/enhanced_check_box.py (+5/-2)
ubuntu_sso/qt/forgotten_password_page.py (+18/-4)
ubuntu_sso/qt/gui.py (+13/-7)
ubuntu_sso/qt/main.py (+13/-1)
ubuntu_sso/qt/network_detection_page.py (+8/-8)
ubuntu_sso/qt/reset_password_page.py (+11/-2)
ubuntu_sso/qt/setup_account_page.py (+18/-10)
ubuntu_sso/qt/sign_in_page.py (+2/-4)
ubuntu_sso/qt/tests/__init__.py (+22/-2)
ubuntu_sso/qt/tests/test_current_user_sign_in_page.py (+32/-22)
ubuntu_sso/qt/tests/test_email_verification.py (+9/-11)
ubuntu_sso/qt/tests/test_enhanced_check_box.py (+0/-7)
ubuntu_sso/qt/tests/test_forgotten_password.py (+31/-9)
ubuntu_sso/qt/tests/test_network_detection.py (+2/-4)
ubuntu_sso/qt/tests/test_reset_password.py (+77/-31)
ubuntu_sso/qt/tests/test_setup_account.py (+50/-3)
ubuntu_sso/qt/tests/test_sign_in_page.py (+2/-2)
ubuntu_sso/qt/tests/test_ubuntu_sso_wizard.py (+2/-2)
ubuntu_sso/qt/ubuntu_sso_wizard.py (+1/-0)
ubuntu_sso/tests/__init__.py (+8/-8)
ubuntu_sso/utils/__init__.py (+9/-3)
ubuntu_sso/utils/runner/glib.py (+11/-2)
ubuntu_sso/utils/runner/tests/test_glib.py (+132/-0)
ubuntu_sso/utils/runner/tests/test_qt.py (+9/-1)
ubuntu_sso/utils/runner/tests/test_runner.py (+9/-7)
ubuntu_sso/utils/runner/tx.py (+9/-1)
ubuntu_sso/utils/tests/test_common.py (+1/-2)
ubuntu_sso/utils/ui.py (+8/-3)
| Changed in ubuntu-sso-client: | |
| status: | New → Triaged |
| assignee: | nobody → Diego Sarmentero (diegosarmentero) |
| importance: | Undecided → High |
| Changed in ubuntu-sso-client: | |
| status: | Triaged → In Progress |
To post a comment you must log in.
