team visibility field changes the name, but I cannot see that
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Steve Kowalik |
Bug Description
There are two defects cause by recent changes to permit entitled users to create private teams.
1. Setting the visibility to private changes the team name, but since the visibility field was move from the third position to the last position, I cannot see that. The visibility really should be in the first or third position.
2. The visibility adds the private- prefix to the name, which is guarded by the blacklist. Only commerical admins can create a team with a name that starts with private-. The form errors and it is not obvious how to address the issue.
* Stop adding the prefix when the visibility is set to private.
It is rarely used. Team owners do not give a toss if their team name can be deduced.
* Otherwise we need to fix bug 494801 which does not help the user create the team on the first submit
* Extra credit, when visibility is set to private, set the subscription policy to restricted
private teams must be restricted, but the form does not update so I get an error.
This is an old issue, but I cannot find a bug about it
Related branches
- Ian Booth (community): Approve
- Curtis Hovey (community): Approve (code)
-
Diff: 314 lines (+52/-76)10 files modifiedlib/lp/registry/browser/team.py (+9/-3)
lib/lp/registry/browser/tests/private-team-creation-views.txt (+2/-1)
lib/lp/registry/browser/tests/test_team.py (+16/-0)
lib/lp/registry/interfaces/person.py (+0/-3)
lib/lp/registry/model/person.py (+6/-7)
lib/lp/registry/templates/people-newteam.pt (+0/-1)
lib/lp/registry/templates/person-macros.pt (+0/-36)
lib/lp/registry/templates/team-edit.pt (+0/-5)
lib/lp/registry/tests/test_person.py (+14/-17)
lib/lp/services/fields/__init__.py (+5/-3)
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Fixed in stable r14816 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 14816>.