Ubuntu Accomplishments System

My Trophies / Opportunities buttons don't depress when selected

Bug #951227 reported by Jono Bacon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Accomplishments System
Fix Released
Medium
Simon Watson

Bug Description

The My Trophies and Opportunities buttons should be depressed to indicate which view is being shown. Currently they don't do this.

Unfortunately, when I looked into this last night this was a little more complex than I expected. I changed the buttons to ToggleButtons and thought it would be as simple as using set_active() where appropriate. Unfortunately, I had all kinds of issues with this...primarily because set_active() doesn't just make it look depressed, but actually sends the signal.

To get around this I tried to block the signals, run set_active(), and then unblock, but it kept calling the signals oddly.

If someone with some GTK experience has a chance to look into this, that would be great!

Jono Bacon (jonobacon)
Changed in ubuntu-accomplishments-system:
status: New → Confirmed
importance: Undecided → Medium
Simon Watson (simon-swat)
Changed in ubuntu-accomplishments-system:
assignee: nobody → Simon Watson (simon-swat)
Simon Watson (simon-swat)
Changed in ubuntu-accomplishments-system:
status: Confirmed → Fix Committed
Revision history for this message
Jono Bacon (jonobacon) wrote :

Simon, why did you set this to Fix Committed? There is no fix in the codebase for this bug yet.

Please don't set bug status unless a fix has been applied to the main codebase, thanks!

Changed in ubuntu-accomplishments-system:
status: Fix Committed → Confirmed
assignee: Simon Watson (simon-swat) → nobody
Revision history for this message
Simon Watson (simon-swat) wrote :

Fix now available in attached branch. Apologies for the earlier mistake. Bit of a brainfreeze between the difference between committing in bazaar and commiting in subversion!

Changed in ubuntu-accomplishments-system:
status: Confirmed → In Progress
assignee: nobody → Simon Watson (simon-swat)
status: In Progress → Fix Committed
Revision history for this message
Jono Bacon (jonobacon) wrote :

Thanks, Simon. I am currently on vacation, but will review this soon. I need to review another big branch from Duncan first and then when I merge that in I will get your branch reviewed. Thanks!

Revision history for this message
Jono Bacon (jonobacon) wrote :

Thanks, Simon, for the fantastic fix! I have merged this in and I am marking this bug as fixed. :-)

Changed in ubuntu-accomplishments-system:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.