branch-puller lacks end-to-end tests

Bug #95319 reported by David Allouche
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Jonathan Lange

Bug Description

I recently go a patch through review and pqm that "fixed" the branch puller into requiring that source locations be always URI. But the authserver gives absolute paths as source for hosted branches. So rolling out this change without fixing it would have broken the branch hosting service. If there had been some end-to-end test for the branch puller, the problem would have been detected earlier, or at worst it would have require a simultaneous update of the authserver and the branch puller.

The branch-puller needs end-to-end tests. The list of branches starting with rows in the database, going through the authserver, the xmlrpc, and finally the branch-puller script. The branch data starting from the filesystem (for hosted branches) and one or two http servers (for import and mirror branches) and copied to the filesystem.

Tags: lp-code
Revision history for this message
Jonathan Lange (jml) wrote :

Feel free to take this from me.

Changed in launchpad-bazaar:
assignee: nobody → jml
importance: Undecided → High
status: New → Triaged
Revision history for this message
Tim Penhey (thumper) wrote :

Jono, do you think that the staging stack and running puller on launchpad.dev fixes this?

Revision history for this message
Jonathan Lange (jml) wrote :

No, it doesn't. Fixing this properly requires _automated_ end-to-end tests.

In fact, this only requires one test, I think.

Deferring to 1.1.9

Revision history for this message
Jonathan Lange (jml) wrote :

In review queue, depends on local-pull-n-scan work.

Changed in launchpad-bazaar:
status: Triaged → In Progress
Jonathan Lange (jml)
Changed in launchpad-bazaar:
status: In Progress → Fix Committed
Jonathan Lange (jml)
Changed in launchpad-bazaar:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.