Checkbox

Apport should prompt when failing a test during development

Bug #959463 reported by Marc Tardif on 2012-03-19

This bug affects 3 people

Affects		Status	Importance	Assigned to	Milestone
	Checkbox	Fix Released	High	Marc Tardif	Checkbox 0.13.5 "precise_fixes_3"

Bug Description

When failing a test on Precise, there is no apport prompt that appears. Instead, this trace appears on the log:

2012-03-19 12:02:52,723 ERROR Error running event handler ../../checkbox/trunk/plugins/apport_prompt.py ApportPrompt.prompt_test(<checkbox_gtk.gtk_interface.GTKInterface object at 0x1fcf590>, {'status': 'fail', 'data': '', 'description': u"1. Open Dash, input 'Nautilus' and select 'Home folder'\n -> Nautilus is opened, Home Folder is selected\n2. In Home Folder right click on a blank section and select Create Document, Empty Document. Name the resulting file moveme.txt.\n -> Empty document moveme.txt is created", 'plugin': 'manual', 'suite': '__nautilus__', 'type': 'test', 'requires': ["package.name == 'nautilus'"], 'resources': [{'status': 'Installed', 'desired': 'Install', 'version': '1:3.3.91-0ubuntu4', 'name': 'nautilus', 'description': 'file manager and graphical shell for GNOME'}], 'name': 'nautilus/TC-NFM-001'}) for event type 'prompt-test'
Traceback (most recent call last):
  File "/home/dev/src/checkbox/trunk/checkbox/reactor.py", line 74, in fire
    results.append(handler(*args, **kwargs))
  File "../../checkbox/trunk/plugins/apport_prompt.py", line 229, in prompt_test
    'suite:' : test["suite"]}
KeyError: 'suite'

Related branches

lp:~cr3/checkbox/959463

Merged into lp:checkbox at revision 1332

Daniel Manrique (community): Approve on 2012-03-20

lp:~roadmr/ubuntu/precise/checkbox/0.13.5

Merged into lp:ubuntu/precise/checkbox at revision 41

Ubuntu Sponsors: Pending requested 2012-03-21

Diff: 101688 lines (+21514/-14618)

123 files modified

checkbox/application.py (+1/-1)
checkbox/user_interface.py (+15/-34)
checkbox_qt/qt_interface.py (+25/-12)
debian/changelog (+57/-0)
debian/po/cs.po (+2/-2)
debian/po/de.po (+2/-2)
debian/po/en_AU.po (+2/-2)
debian/po/en_GB.po (+2/-2)
debian/po/es.po (+2/-2)
debian/po/fr.po (+2/-2)
debian/po/he.po (+2/-2)
debian/po/hu.po (+2/-2)
debian/po/it.po (+2/-2)
debian/po/ja.po (+2/-2)
debian/po/nl.po (+2/-2)
debian/po/oc.po (+2/-2)
debian/po/pl.po (+2/-2)
debian/po/pt_BR.po (+2/-2)
debian/po/ro.po (+2/-2)
debian/po/ru.po (+2/-2)
debian/po/uk.po (+2/-2)
debian/po/zh_TW.po (+2/-2)
jobs/keys.txt.in (+1/-1)
jobs/mediacard.txt.in (+16/-16)
jobs/optical.txt.in (+10/-9)
jobs/suspend.txt.in (+1/-1)
plugins/apport_prompt.py (+3/-4)
plugins/user_interface.py (+23/-0)
po/ace.po (+146/-144)
po/af.po (+146/-144)
po/am.po (+148/-146)
po/ar.po (+146/-144)
po/ast.po (+164/-157)
po/az.po (+95/-93)
po/be.po (+146/-144)
po/bg.po (+146/-144)
po/bn.po (+146/-144)
po/bo.po (+146/-144)
po/br.po (+146/-144)
po/bs.po (+146/-144)
po/ca.po (+230/-180)
po/ca@valencia.po (+146/-144)
po/ckb.po (+120/-93)
po/cs.po (+1030/-200)
po/cy.po (+148/-146)
po/da.po (+346/-148)
po/de.po (+742/-667)
po/dv.po (+148/-146)
po/el.po (+68/-66)
po/en_AU.po (+733/-685)
po/en_CA.po (+146/-144)
po/en_GB.po (+719/-717)
po/eo.po (+146/-144)
po/es.po (+505/-189)
po/et.po (+146/-144)
po/eu.po (+146/-144)
po/fa.po (+148/-146)
po/fi.po (+196/-145)
po/fr.po (+254/-144)
po/ga.po (+148/-146)
po/gd.po (+146/-144)
po/gl.po (+147/-145)
po/he.po (+146/-144)
po/hi.po (+146/-144)
po/hr.po (+146/-144)
po/hu.po (+211/-145)
po/hy.po (+148/-146)
po/id.po (+148/-146)
po/is.po (+146/-144)
po/it.po (+1158/-205)
po/ja.po (+146/-144)
po/jbo.po (+148/-146)
po/ka.po (+148/-146)
po/kk.po (+146/-144)
po/km.po (+148/-146)
po/kn.po (+148/-146)
po/ko.po (+195/-165)
po/ku.po (+148/-146)
po/ky.po (+148/-146)
po/lt.po (+146/-144)
po/lv.po (+146/-144)
po/mk.po (+148/-146)
po/ml.po (+148/-146)
po/mr.po (+148/-146)
po/ms.po (+95/-93)
po/my.po (+146/-144)
po/nb.po (+146/-144)
po/nds.po (+148/-146)
po/ne.po (+146/-144)
po/nl.po (+44/-44)
po/nn.po (+146/-144)
po/oc.po (+147/-145)
po/pl.po (+146/-144)
po/ps.po (+148/-146)
po/pt.po (+146/-144)
po/pt_BR.po (+199/-149)
po/ro.po (+1349/-239)
po/ru.po (+44/-44)
po/sd.po (+44/-44)
po/shn.po (+148/-146)
po/si.po (+148/-146)
po/sk.po (+68/-66)
po/sl.po (+799/-173)
po/sq.po (+146/-144)
po/sr.po (+148/-146)
po/sv.po (+146/-144)
po/ta.po (+152/-145)
po/te.po (+152/-150)
po/th.po (+146/-144)
po/tr.po (+1102/-199)
po/ug.po (+1309/-191)
po/uk.po (+45/-45)
po/ur.po (+148/-146)
po/uz.po (+148/-146)
po/vi.po (+146/-144)
po/zh_CN.po (+147/-145)
po/zh_HK.po (+146/-144)
po/zh_TW.po (+146/-144)
qt/frontend/qtfront.cpp (+75/-35)
qt/frontend/qtfront.h (+12/-7)
qt/frontend/qtfront.ui (+102/-35)
scripts/removable_storage_test (+3/-2)
scripts/removable_storage_watcher (+11/-11)

lp:ubuntu/precise/checkbox

Revision history for this message

Marc Tardif (cr3) wrote on 2012-03-19:

After fixing the reference to test["suite"], this trace then appears in the log:

Traceback (most recent call last):
  File "/home/dev/src/checkbox/trunk/checkbox/reactor.py", line 74, in fire
    results.append(handler(*args, **kwargs))
  File "../../checkbox/trunk/plugins/apport_prompt.py", line 255, in prompt_test
    apport_interface.run_report_bug()
  File "/usr/lib/python2.7/dist-packages/apport/ui.py", line 388, in run_report_bug
    if response['report']:
TypeError: string indices must be integers, not str

Changed in checkbox:
assignee:	nobody → Marc Tardif (cr3)
importance:	Undecided → High
status:	New → In Progress

Revision history for this message

Marc Tardif (cr3) wrote on 2012-03-19:

This requires fixing the reference to test["suite"] and the return value of ui_present_report_details.

Daniel Manrique (roadmr) on 2012-03-20

Changed in checkbox:
status:	In Progress → Fix Committed
milestone:	none → 0.13.5

Ara Pulido (ara) on 2012-03-22

Changed in checkbox:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

Duplicates of this bug

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.