Evergreen

Acq: "Print Purchase Order" does not print PO Name

Bug #973666 reported by Angela Kilsdonk
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned
Evergreen 2.5.0-m2

Bug Description

Evergreen version: 2.1.1

Printing a PO from the menu option "Actions-->Print Purchase Order" generates a document that displays the PO #, but not the PO Name. It would be helpful if the print document displayed the PO Name instead of the PO #.

See original description
Tags: pullrequest
Angela Kilsdonk (akilsdonk)
description: updated
Michael Peters (mrpeters)
Changed in evergreen:
importance: Undecided → Wishlist
Revision history for this message
Michael Peters (mrpeters) wrote :

Angela,

Are you looking to replace the PO # with the PO Name? Or, would you like something like:

Purchase Order: PO Name (1234)

Either way, this is done via the Action Trigger feature in Evergreen. You're looking for the Event Def called "PO HTML". Just double click somewhere on that line and you'll be taken to the Event Def editor. We want to edit the template at the bottom.

The line in question is:
<h2>Purchase Order [% target.id %]</h2>

So, lets try:
<h2>Purchase Order: [% target.name %] ([% target.id %])</h2>

I think you'll like the result :)

Michael Peters (mrpeters)
Changed in evergreen:
status: New → Opinion
Revision history for this message
Michael Peters (mrpeters) wrote :

For what it's worth, I've pushed user/mrpeters-isl/print_po_include_name which includes this change by default for new installations, should we decide to go that route.

tags: added: pullrequest
Changed in evergreen:
status: Opinion → In Progress
assignee: nobody → Michael Peters (mrpeters)
Michael Peters (mrpeters)
Changed in evergreen:
assignee: Michael Peters (mrpeters) → nobody
Revision history for this message
Angela Kilsdonk (akilsdonk) wrote :

I think "Purchase Order: PO Name (1234)" is a good solution. Libraries that do not replace the default PO Name will see "Purchase Order: 1234 (1234)", but libraries that do assign a PO Name will be able to see both name and #, which I think is desirable.

Thanks for the information on the Action Trigger!

Ben Shum (bshum)
Changed in evergreen:
milestone: none → 2.4.0-rc
status: In Progress → Triaged
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-rc → 2.5.0-alpha
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-m1 → 2.5.0-m2
Revision history for this message
Remington Steed (rjs7) wrote :

This branch is a simple but desirable change, so I have rebased to master and signed off. Thanks Michael!

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/rsteed/print_po_include_name

Revision history for this message
Remington Steed (rjs7) wrote :

For the record, I tested this and it works as described.

Revision history for this message
Dan Wells (dbw2) wrote :

Looks good; pushed. Thanks, all!

Changed in evergreen:
status: Triaged → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.