Odoo Addons (MOVED TO GITHUB)

hr_timesheet_invoice - does not use enforced product

Bug #976223 reported by Ferdinand on 2012-04-07

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Odoo Addons (MOVED TO GITHUB)	Fix Released	Low	OpenERP R&D Addons Team 3

Bug Description

If enforce product is set it should be used also in case ther is no product in account analytic line

BTW the message
"At least one line has no product"
is not helpful if the user is invoicing some 100 positions

OpenERP should report
* number of lines without product_id
* some info like line.name to allow the user to identify the problematic lines

Related branches

lp:~openerp-dev/openobject-addons/trunk-bug-976233-rmu

Rejected for merging into lp:openobject-addons

Amit Parik (community): Approve on 2012-04-30

Revision history for this message

Ferdinand (office-chricar) wrote on 2012-04-07:

hr_timesheet_invoice_create.py.20120407.patch Edit (759 bytes, text/x-diff)

summary:

- hr_timesheet_invoice - does not use enforce product
+ hr_timesheet_invoice - does not use enforced product

Ravish(OpenERP) (rmu-openerp) on 2012-04-09

Changed in openobject-addons:
status:	New → Confirmed
importance:	Undecided → Low
assignee:	nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)

Revision history for this message

Ravish(OpenERP) (rmu-openerp) wrote on 2012-04-30:

Hello ,

It has been fixed on lp:~openerp-dev/openobject-addons/trunk-bug-976233-rmu with following Revision number and revision ID

Revision Number : 6768
Revision ID: <email address hidden>

This will merge soon with trunk

Thanks !!

Changed in openobject-addons:
status:	Confirmed → Fix Committed

Revision history for this message

qdp (OpenERP) (qdp) wrote on 2012-07-26:

Hi Ferdinand,

Your proposal has been merged to trunk in revision 7124. It includes a better warning message and will not raise any error if we set the product through the wizard.

The final fix is slightly different than the above one, btw.

Thanks for the contribution,
Quentin