Ubuntu
shimmer-themes package

Greybird metacity window title off-centre

Bug #982820 reported by Jo Franklin
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
shimmer-themes (Ubuntu)
Fix Released
Undecided
Simon Steinbeiß

Bug Description

Not sure if this is a bug or a feature but the Greybird metacity window title is off-centre.

This is due to the following lines of code in /usr/share/themes/Greybird/metacity-1/metacity-theme-1.xml

<!-- ::: TITLES ::: -->
<draw_ops name="title">
 <title color="shade/gtk:bg[NORMAL]/1.30" x="((width - title_width) / 2) -36 `max` 0" y="1 `max` ((height-title_height)/2)+1"/>
 <title color="shade/gtk:bg[NORMAL]/0.50" x="((width - title_width) / 2) -36 `max` 0" y="0 `max` ((height-title_height)/2)"/>
</draw_ops>

<draw_ops name="title_unfocused">
 <title color="shade/gtk:bg[NORMAL]/1.15" x="((width - title_width) / 2) -36 `max` 0" y="1 `max` ((height-title_height)/2)+1"/>
 <title color="shade/gtk:bg[NORMAL]/0.70" x="((width - title_width) / 2) -36 `max` 0" y="0 `max` ((height-title_height)/2)"/>
</draw_ops>

To centre the titles the "-36" should be changed to "-0".

This also exists upstream in the theme available from the shimmer project's own website, so may be a design choice rather than a bug.

Revision history for this message
Simon Steinbeiß (ochosi) wrote :

Hi, I wasn't really aware of that (I personally don't use metacity, and it's been a while since I added support for it in Greybird).
I'm willing to fix this - could you please supply screenshots for the "-36" and "-0"? Thanks!

Changed in shimmer-themes (Ubuntu):
assignee: nobody → Simon Steinbeiß (simon-steinbeiss)
Revision history for this message
Simon Steinbeiß (ochosi) wrote :

I tested this a bit myself now and in fact setting that value to 0 doesn't really center the title, at least not relative to the window-width (but to the title-element).

The -36 centers the title in a setup like this: "close,max,min:"
If you use ":min,max,close" things look different obviously (always keep in mind that the title only gets centered within the title-element).

But anyway, setting the value to 0 sounds like a good compromise because it works reasonably well with all kinds of button-setups. The fix is in this commit: https://github.com/shimmerproject/Greybird/commit/788f2e84485a3afa43ba0407ab106d135a3bdf8e

Changed in shimmer-themes (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package shimmer-themes - 1.5.0-0ubuntu1

---------------
shimmer-themes (1.5.0-0ubuntu1) quantal; urgency=low

  * Update Greybird to latest tag (v0.9). lp: #924853,#947436,#982820,#1016713
  * Update Bluebird to latest tag (v0.6). lp: #686239,#977431
  * Update Albatross to latest tag (v1.2). lp: #989814,#1023056
  * debian/control: demote gtk3-engines-unico to recommends as most themes
    are now engine-free.
  * debian/shimmer-wallpapers.install: update paths, wallpapers are in their
    own branch/subtarball now.
  * debian/shimmer-themes.install: ship Albatross' metacity theme.
  * debian/shimmer-themes.links: drop greybird -> Greybird compatibility
    symlinks. lp: #985320
 -- Lionel Le Folgoc <email address hidden> Sat, 28 Jul 2012 22:28:31 +0200

Changed in shimmer-themes (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.