MASTER mozilla-thunderbird crashed [@nsLookAndFeel::InitColors] [@nsLookAndFeel::LookAndFeelChanged]

Bug #98831 reported by Fabien Paulot
66
Affects Status Importance Assigned to Milestone
Mozilla Thunderbird
Fix Released
High
mozilla-thunderbird (Ubuntu)
Fix Released
High
Mozilla Bugs

Bug Description

Binary package hint: mozilla-thunderbird

I was changing the parameters used by murrine (using the guy). When those new parameters were applied, every application succeeded in reloading (i.e. firefox, listen ...) but thunderbird.

ProblemType: Crash
Architecture: i386
CrashCounter: 1
Date: Thu Mar 29 18:45:14 2007
DistroRelease: Ubuntu 7.04
ExecutablePath: /usr/lib/mozilla-thunderbird/mozilla-thunderbird-bin
Package: mozilla-thunderbird 1.5.0.10-0ubuntu2
PackageArchitecture: i386
ProcCmdline: /usr/lib/mozilla-thunderbird/mozilla-thunderbird-bin
ProcCwd: /home/fabien
ProcEnviron:
 LANGUAGE=fr_FR.UTF-8
 PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/bin/X11:/usr/games
 LANG=fr_FR.UTF-8
 SHELL=/bin/bash
Signal: 11
SourcePackage: mozilla-thunderbird
StacktraceTop:
 __kernel_vsyscall ()
 raise () from /lib/tls/i686/cmov/libpthread.so.0
 ?? ()
 ?? ()
 ?? ()
Uname: Linux Aurora 2.6.20-13-generic #2 SMP Sun Mar 25 00:21:25 UTC 2007 i686 GNU/Linux
UserGroups: adm admin audio cdrom dialout dip floppy lpadmin plugdev scanner video

From the retraced stack trace:
...
#3 <signal handler called>
#4 nsLookAndFeel::InitColors () at nsLookAndFeel.cpp:500
#5 nsLookAndFeel::LookAndFeelChanged (this=0x812ffe0) at nsLookAndFeel.cpp:569
#6 nsPresContext::ThemeChanged (this=0x839d3c8) at nsPresContext.cpp:1190
#7 PresShell::HandleEvent (this=0x83a0ee8, aView=0x83c4328, aEvent=0xbfe3f7c8,
#8 nsViewManager::HandleEvent (this=0x83a0a20, aView=0x83a0a98, aEvent=0xbfe3f7c8, aCaptured=0)
#9 nsViewManager::DispatchEvent (this=0x83a0a20, aEvent=0xbfe3f7c8, aStatus=0xbfe3f770)
#10 HandleEvent (aEvent=0xbfe3f7c8) at nsView.cpp:171
#11 nsCommonWidget::DispatchEvent (this=0x83a0b00, aEvent=0xbfe3f7c8, aStatus=@0xbfe3f7f8)
#12 nsWindow::ThemeChanged (this=0x83a0b00) at nsWindow.cpp:19
...

Revision history for this message
In , Mozilla (mozilla) wrote :

This seems to happen if gnome-settings-daemon takes over control over gtk settings from gtk configfiles since it happens reproducable if gnome-settings-daemon is started or killed. So it could be that a bug in GTK triggers the crash (while I'm not an expert in GTK space)

Revision history for this message
In , Timeless-bemail (timeless-bemail) wrote :

http://mxr-test.landfill.bugzilla.org/mxr-test/gnome/source/gtk+/gtk/gtkrc.c#1817
1829 g_return_val_if_fail (GTK_IS_SETTINGS (settings), NULL);

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/widget/src/gtk2/nsLookAndFeel.cpp&mark=500,503&rev=1.23.8.1#494

Incident ID: 28173161
Stack Signature nsLookAndFeel::InitColors() 5d9ddc6c
Product ID Firefox2
Build ID 2006120814
Trigger Time 2007-01-09 00:08:10.0
Platform LinuxIntel
Operating System Linux 2.6.18.2-34-default
Module firefox-bin + (001f1b94)
URL visited
User Comments started gnome-font-properties (and therefore gnome-session-daemon)
Since Last Crash 0 sec
Total Uptime 0 sec
Trigger Reason SIGSEGV: Segmentation Fault: (signal 11)
Source File, Line No. /builds/tinderbox/Fx-Mozilla1.8-release/Linux_2.4.21-27.0.4.EL_Depend/mozilla/widget/src/gtk2/nsLookAndFeel.cpp, line 503
Stack Trace

nsLookAndFeel::InitColors() [mozilla/widget/src/gtk2/nsLookAndFeel.cpp, line 503]
nsLookAndFeel::LookAndFeelChanged() [mozilla/widget/src/gtk2/nsLookAndFeel.cpp, line 575]
nsPresContext::ThemeChanged() [mozilla/layout/base/nsPresContext.cpp, line 1207]
PresShell::HandleEvent() [mozilla/layout/base/nsPresShell.cpp, line 6064]
nsViewManager::HandleEvent() [mozilla/view/src/nsViewManager.cpp, line 848]
nsViewManager::DispatchEvent() [mozilla/view/src/nsViewManager.cpp, line 2246]
HandleEvent() [mozilla/view/src/nsView.cpp, line 251]
nsCommonWidget::DispatchEvent() [mozilla/widget/src/gtk2/nsCommonWidget.cpp, line 219]
nsWindow::ThemeChanged() [mozilla/widget/src/gtk2/nsWindow.cpp, line 2010]
nsWindow::ThemeChanged() [mozilla/widget/src/gtk2/nsWindow.cpp, line 2023]
libgobject-2.0.so.0 + 0x167d9 (0xf79a37d9)
libgobject-2.0.so.0 + 0x9c0b (0xf7996c0b)
libgobject-2.0.so.0 + 0x1b021 (0xf79a8021)
libgobject-2.0.so.0 + 0x1c247 (0xf79a9247)
libgobject-2.0.so.0 + 0x1c415 (0xf79a9415)
libgobject-2.0.so.0 + 0xe051 (0xf799b051)
libgobject-2.0.so.0 + 0xa9df (0xf79979df)
libgobject-2.0.so.0 + 0xe761 (0xf799b761)
libgtk-x11-2.0.so.0 + 0x19113b (0xf7c5b13b)
libgtk-x11-2.0.so.0 + 0x1798e4 (0xf7c438e4)
libgtk-x11-2.0.so.0 + 0x179c23 (0xf7c43c23)
libgobject-2.0.so.0 + 0x167d9 (0xf79a37d9)
libgobject-2.0.so.0 + 0x9c0b (0xf7996c0b)
libgobject-2.0.so.0 + 0x1ad3d (0xf79a7d3d)
libgobject-2.0.so.0 + 0x1c247 (0xf79a9247)
libgobject-2.0.so.0 + 0x1c415 (0xf79a9415)
libgobject-2.0.so.0 + 0xe051 (0xf799b051)
libgobject-2.0.so.0 + 0xa9df (0xf79979df)
libgobject-2.0.so.0 + 0xfc02 (0xf799cc02)
libgtk-x11-2.0.so.0 + 0x1932f6 (0xf7c5d2f6)
libgtk-x11-2.0.so.0 + 0x12c7b8 (0xf7bf67b8)
libgdk-x11-2.0.so.0 + 0x4202a (0xf7a8a02a)
libglib-2.0.so.0 + 0x2dde2 (0xf7921de2)
libglib-2.0.so.0 + 0x30e1f (0xf7924e1f)
libglib-2.0.so.0 + 0x311c9 (0xf79251c9)
libgtk-x11-2.0.so.0 + 0x12ccd4 (0xf7bf6cd4)
nsAppShell::Run() [mozilla/widget/src/gtk2/nsAppShell.cpp, line 141]
nsAppStartup::Run() [mozilla/toolkit/components/startup/src/nsAppStartup.cpp, line 152]
XRE_main() [mozilla/toolkit/xre/nsAppRunner.cpp, line 2446]
main() [mozilla/browser/app/nsBrowserApp.cpp, line 62]
libc.so.6 + 0x15f9c (0xf73b8f9c)

crash is simple. style is null.

Revision history for this message
In , Mozilla (mozilla) wrote :

Created attachment 251041
trunk patch

This only adds an if (style) around the code.

Revision history for this message
In , Mozilla (mozilla) wrote :

Created attachment 251043
patch #2 (trunk)

I guess I was a bit fast with the first one :-(

Revision history for this message
In , Roc-ocallahan (roc-ocallahan) wrote :

If style is null the results are pretty bad, right? These colors don't get initialized?

Revision history for this message
In , Mozilla (mozilla) wrote :

As it only happens for me if control is switched from gnome-settings-daemon to config-file based config (where I don't know at all what GTK is doing exactly) I've just checked what happens now if I kill gnome-settings-daemon when I had a different theme configured in it.
Firefox still changed it's menu colors so I guess we have more than one event and the changes still get applied.

Revision history for this message
In , Mozilla (mozilla) wrote :

I also checked tooltip colors and it still seems to work as expected.

Revision history for this message
In , Mozilla (mozilla) wrote :

Created attachment 251159
patch (1.8)

That's the same for 1.8 branch.

Revision history for this message
In , Mozilla (mozilla) wrote :

commited to trunk and waiting some time until requesting approval for 1.8branch.

Revision history for this message
In , Mozilla (mozilla) wrote :

Comment on attachment 251159
patch (1.8)

Fixes a crasher on Linux which can easily happen if you don't run Gnome.

Revision history for this message
In , Dveditz (dveditz) wrote :

Comment on attachment 251159
patch (1.8)

approved for 1.8 branch, a=dveditz for drivers

Revision history for this message
Fabien Paulot (fabienpaulot) wrote : [apport] mozilla-thunderbird-bin crashed with SIGSEGV in __kernel_vsyscall()

Binary package hint: mozilla-thunderbird

I was changing the parameters used by murrine (using the guy). When those new parameters, every application succeeded in reloading (i.e. firefox, listen ...) but thunderbird.

ProblemType: Crash
Architecture: i386
CrashCounter: 1
Date: Thu Mar 29 18:45:14 2007
DistroRelease: Ubuntu 7.04
ExecutablePath: /usr/lib/mozilla-thunderbird/mozilla-thunderbird-bin
Package: mozilla-thunderbird 1.5.0.10-0ubuntu2
PackageArchitecture: i386
ProcCmdline: /usr/lib/mozilla-thunderbird/mozilla-thunderbird-bin
ProcCwd: /home/fabien
ProcEnviron:
 LANGUAGE=fr_FR.UTF-8
 PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/bin/X11:/usr/games
 LANG=fr_FR.UTF-8
 SHELL=/bin/bash
Signal: 11
SourcePackage: mozilla-thunderbird
StacktraceTop:
 __kernel_vsyscall ()
 raise () from /lib/tls/i686/cmov/libpthread.so.0
 ?? ()
 ?? ()
 ?? ()
Uname: Linux Aurora 2.6.20-13-generic #2 SMP Sun Mar 25 00:21:25 UTC 2007 i686 GNU/Linux
UserGroups: adm admin audio cdrom dialout dip floppy lpadmin plugdev scanner video

Revision history for this message
Fabien Paulot (fabienpaulot) wrote :
description: updated
Revision history for this message
Ketil Malde (ketil-ii) wrote : me too

This happens for me to (same stack backtrace). I don't get SEGV, but "Illegal instruction", if that matters.

Revision history for this message
Hilario J. Montoliu (hjmf) (hmontoliu) wrote : Retraced Stacktrace

Retrace done:
...
#3 <signal handler called>
#4 nsLookAndFeel::InitColors () at nsLookAndFeel.cpp:500
 style = (GtkStyle *) 0x0
 accel_label = <value optimized out>
 menuitem = (GtkWidget *) 0xbfe3f4e8
 menu = (GtkWidget *) 0xb7c85375
 parent = (GtkWidget *) 0x8d6a828
 button = (GtkWidget *) 0x80ed058
 label = <value optimized out>
 window = (GtkWidget *) 0xb675088b
#5 0xb67511e0 in nsLookAndFeel::LookAndFeelChanged (this=0x812ffe0) at nsLookAndFeel.cpp:569

#6 0xb53daaf8 in nsPresContext::ThemeChanged (this=0x839d3c8) at nsPresContext.cpp:1190

#7 0xb53e6ca8 in PresShell::HandleEvent (this=0x83a0ee8, aView=0x83c4328, aEvent=0xbfe3f7c8,
    aEventStatus=0xbfe3f610, aForceHandle=0, aHandled=@0xbfe3f608) at nsPresShell.cpp:6063
...

Tagging as mt-confirm for further processing

Revision history for this message
Hilario J. Montoliu (hjmf) (hmontoliu) wrote : Retraced Thread Stacktrace

Retraced Thread Stacktrace

Changed in mozilla-thunderbird:
assignee: nobody → mozilla-bugs
status: Unconfirmed → Needs Info
Changed in mozilla-thunderbird:
importance: Undecided → Medium
description: updated
Changed in mozilla-thunderbird:
importance: Medium → High
Revision history for this message
Hilario J. Montoliu (hjmf) (hmontoliu) wrote : Re: MASTER mozilla-thunderbird-bin crashed [@nsLookAndFeel::InitColors]

Upstream's Bug # 366410 – ff/tb crashes when gtk settings are changed [@nsLookAndFeel::InitColors()] (URL: https://bugzilla.mozilla.org/show_bug.cgi?id=366410)

Changed in mozilla-thunderbird:
status: Needs Info → Confirmed
status: Confirmed → In Progress
Changed in thunderbird:
status: Unknown → Fix Released
Revision history for this message
Hilario J. Montoliu (hjmf) (hmontoliu) wrote :

Possible test case as posted by C4llumD on bug 116873 [1] (for KDE):

While Thunderbird is running:
kcontrol -> Appearances & Themes -> Style

On the Style tab select Widget Style "Keramik" -> Configure

Check/uncheck either of the boxes, OK -> Apply and Thunderbird will crash within a couple of seconds as KDE applies the changes.

[1] https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/116873

Revision history for this message
Alexander Sack (asac) wrote :

was fixed long time ago in tbird 2.0.0.2

Changed in mozilla-thunderbird:
status: In Progress → Fix Released
Changed in thunderbird:
importance: Unknown → High
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.