IArchive.commercial is misleading name
Bug #994644 reported by
Jonathan Lange
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Undecided
|
Jonathan Lange | ||
Bug Description
Currently, IArchive has a 'commercial' attribute. This is misleading. The attribute is only incidentally related to an archive being commercial. What it really does is control whether users get subscription emails (we don't want Ubuntu Software Center users to get mail from Launchpad).
Related branches
lp:~jml/launchpad/commercial-means-shut-up
- Brad Crittenden (community): Approve (code)
-
Diff: 532 lines (+109/-73)15 files modifiedlib/lp/registry/interfaces/person.py (+5/-2)
lib/lp/registry/model/person.py (+4/-3)
lib/lp/soyuz/browser/archive.py (+16/-6)
lib/lp/soyuz/configure.zcml (+4/-3)
lib/lp/soyuz/interfaces/archive.py (+15/-6)
lib/lp/soyuz/mail/notifications.py (+4/-3)
lib/lp/soyuz/model/archive.py (+17/-7)
lib/lp/soyuz/stories/ppa/xx-ppa-workflow.txt (+9/-7)
lib/lp/soyuz/stories/webservice/xx-archive-commercial.txt (+2/-1)
lib/lp/soyuz/stories/webservice/xx-archive.txt (+5/-5)
lib/lp/soyuz/tests/test_archive.py (+13/-18)
lib/lp/soyuz/tests/test_archive_privacy.py (+2/-1)
lib/lp/soyuz/tests/test_archive_subscriptions.py (+1/-1)
lib/lp/soyuz/tests/test_person_createppa.py (+6/-5)
lib/lp/testing/factory.py (+6/-5)
| Changed in launchpad: | |
| status: | New → In Progress |
| assignee: | nobody → Jonathan Lange (jml) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r15209 <http://