Lineitem alerts not displayed scoped to org unit
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Medium
|
Bill Erickson |
Bug Description
To quote Sharon Herbert of Sitka:
---
Instead of scoping to the owning org unit, line item alerts are visible to all org units. This especially
causes a problem when multiple libraries have created the same line item alerts and cannot tell which
one belongs to their org unit.
---
I can address this issue myself.
For reference, lineitem alerts are embodied by rows in acq.lineitem_note where the alert_text column is not null and refers to a row in acq.lineitem_
The controlled vocabulary of acq lineitem alert text is set up in an interface labeled "Line Item Alerts" in the staff client admin menu. In the PO and selection list interfaces (where alerts can be applied), we will limit the user to selecting alerts from those owned at the user's workstation org unit (or its ancestors).
When we display applied alerts, we can also display the shortname of the org unit at which the alert text is defined (the owning_lib column). This should help clarify what's going on with alerts that have already been applied using alert text from another org unit.
tags: | added: pullrequest |
Changed in evergreen: | |
milestone: | 2.2.0rc1 → 2.2.0 |
Changed in evergreen: | |
assignee: | nobody → Bill Erickson (erickson-esilibrary) |
status: | New → In Progress |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
Here's a patch that implements what I outlined in the description of this Launchpad bug: http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ senator/ lp996033
This is suitable for master and backport to 2.2 at least.