juju should complain/error on unknown charm metadata
Bug #999338 reported by
Kapil Thangavelu
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Juju Charm Tools |
Fix Released
|
High
|
Marco Ceppi | ||
| pyjuju |
Triaged
|
Low
|
Unassigned | ||
Bug Description
For local charms, refuse to deploy in the face of unknown metadata fields. For remote charms log warning.
Additional Details
https:/
Related branches
lp:~clint-fewbar/charm-tools/check-metadata
- charmers: Pending requested
-
Diff: 270 lines (+134/-25)15 files modifiedscripts/proof (+41/-7)
tests/charms/unknown-metadata/README.ex (+5/-0)
tests/charms/unknown-metadata/hooks/install (+5/-0)
tests/charms/unknown-metadata/hooks/relation-name-relation-broken (+2/-0)
tests/charms/unknown-metadata/hooks/relation-name-relation-changed (+9/-0)
tests/charms/unknown-metadata/hooks/relation-name-relation-departed (+5/-0)
tests/charms/unknown-metadata/hooks/relation-name-relation-joined (+5/-0)
tests/charms/unknown-metadata/hooks/start (+4/-0)
tests/charms/unknown-metadata/hooks/stop (+7/-0)
tests/charms/unknown-metadata/metadata.yaml (+18/-0)
tests/charms/unknown-metadata/revision (+1/-0)
tests/proof/expected/broken-maintainer (+6/-6)
tests/proof/expected/missing-maintainer (+6/-6)
tests/proof/expected/test (+6/-6)
tests/proof/expected/unknown-metadata (+14/-0)
| Changed in juju: | |
| milestone: | none → galapagos |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
Revision history for this message
| Clint Byrum (clint-fewbar) wrote Re: [Bug 999338] [NEW] juju should complain/error on unknown charm metadata | #1 |
| Changed in juju: | |
| milestone: | galapagos → honolulu |
Revision history for this message
| Clint Byrum (clint-fewbar) wrote | #2 |
| Changed in juju: | |
| milestone: | 0.6 → 0.7 |
| Changed in charm-tools: | |
| status: | New → In Progress |
| assignee: | nobody → Clint Byrum (clint-fewbar) |
| importance: | Undecided → High |
| Changed in juju: | |
| milestone: | 0.7 → none |
| tags: | added: charmbrowser |
| Changed in charm-tools: | |
| assignee: | Clint Byrum (clint-fewbar) → Marco Ceppi (marcoceppi) |
| Changed in charm-tools: | |
| status: | In Progress → Triaged |
| Changed in juju: | |
| status: | Confirmed → Triaged |
| Changed in juju: | |
| importance: | Medium → Low |
| Changed in charm-tools: | |
| status: | Triaged → Fix Released |
To post a comment you must log in.
Excerpts from Kapil Thangavelu's message of Mon May 14 21:07:47 UTC 2012:
> Public bug reported:
>
>
> For local charms, refuse to deploy in the face of unknown metadata fields. For remote charms log warning.
>
> Additional Details
> https:/
Note that we should not *refuse*, as this will make any new versions of
charms non-deployable on old versions of juju even when that doesn't
matter. For instance a category field will cause juju to refuse these
charms, even though most of them will remain deployable.
This is also completely inappropriate for galapagos, as it will change
default behavior. If I am overruled on the reject vs. warn route, then
I suggest we delay this to honolulu.