cpu_scaling_test fails even if measured speedup exceeds expected speedup

Bug #999547 reported by Brendan Donegan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox
Fix Released
Medium
Brendan Donegan

Bug Description

As per this output:

ubuntu@201112-10227:/usr/share/checkbox/scripts$ sudo nice -n -20 ./cpu_scaling_test

System Capabilites:
-------------------------------------------------
System has 4 cpus

Supported CPU Frequencies:
    2501 MHz
    2500 MHz
    2400 MHz
    2300 MHz
    2200 MHz
    2100 MHz
    2000 MHz
    1900 MHz
    1800 MHz
    1700 MHz
    1600 MHz

Supported Governors:
    conservative
    ondemand
    userspace
    powersave
    performance

Current governors:
    cpu0: userspace
    cpu1: userspace
    cpu2: userspace
    cpu3: userspace

Userspace Governor Test:
-------------------------------------------------
Setting governor to userspace
Setting CPU frequency to 1600 MHz
Running CPU load test...
pid 13619's current affinity list: 0-3
pid 13619's new affinity list: 0
Minimum frequency load test time: 4.56
Setting CPU frequency to 2501 MHz
Running CPU load test...
pid 13619's current affinity list: 0
pid 13619's new affinity list: 0
Maximum frequency load test time: 2.22
Note: found ida flag, increasing expected speedup by 8.0%

CPU Frequency Speed Up: 1.70
Measured Speed Up: 2.05
Percentage Difference 20.9%
Error: measured speedup vs expected speedup is 20.9% and is not within 10.0% margin.

On Demand Governor Test:
-------------------------------------------------
Setting governor to ondemand
Waiting 5 seconds... done.
Running CPU load test...
pid 13619's current affinity list: 0
pid 13619's new affinity list: 0
On Demand load test time: 2.23
Percentage Difference vs. maximum frequency: 0.5%
Waiting 5 seconds... done.

Performance Governor Test:
-------------------------------------------------
Setting governor to performance
Running CPU load test...
pid 13619's current affinity list: 0
pid 13619's new affinity list: 0
Performance load test time: 2.22
Percentage Difference vs. maximum frequency: 0.0%

Conservative Governor Test:
-------------------------------------------------
Setting governor to conservative
Waiting 10 seconds... done.
Running CPU load test...
pid 13619's current affinity list: 0
pid 13619's new affinity list: 0
Conservative load test time: 4.55
Percentage Difference vs. minimum frequency: 0.2%
Restoring original governor to userspace
ubuntu@201112-10227:/usr/share/checkbox/scripts$ echo $?
1

The cpu_scaling_test script can fail if the measured speedup actually *exceeds* the expected speedup. Obviously this is not a cause for concern so the script should only fail if the measured speedup is less than the expected speedup by a significant amount.

Related branches

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

The test: "if differenceSpeedUp > self.speedUpTolerance" should check if measured speedup < expected speedup too.

Warning:
Since Rev 1490, scripts/cpu_scaling_test => scripts/frequency_governors_test

Changed in checkbox:
status: New → Triaged
importance: Undecided → Medium
Changed in checkbox:
status: Triaged → In Progress
assignee: nobody → Brendan Donegan (brendan-donegan)
Zygmunt Krynicki (zyga)
Changed in checkbox:
status: In Progress → Fix Committed
Changed in checkbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.