Comment 4 for bug 250901

Revision history for this message
Steve Langasek (vorlon) wrote : Re: [Bug 250901] Re: traceback caused by difflimit = 0

On Wed, Jul 23, 2008 at 09:17:01PM -0000, Robert Collins wrote:
> On Tue, 2008-07-22 at 18:35 +0000, James Westby wrote:
> > If difflimit == 0 then it returns None, rather than the "diff too large"
> > string returned if the value is > 0 and the diff is larger than that. Either
> > a string should be returned, or the None value should be handled.

> > However, Steve said that he thought 0 would mean no-limit. I think
> > either that, or using -1 to mean this would be a good idea.

> This is a regression - the docs say use 0 to disable the feature.

FWIW, when I read the docs I understood "the feature" as "the feature of
limiting message size" rather than "the feature of sending mail"; it seemed
obvious to me that there were easier ways to disable sending mail, like by
not configuring a to: address.

So it would be nice if the docs could be clarified too.

--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
<email address hidden> <email address hidden>