Comment 6 for bug 146165
Revision history for this message
| Jelmer Vernooij (jelmer) wrote Re: [Bug 146165] Re: add uses _get_inventory, _write_inventory, but should not | #6 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
On Mon, 2011-05-02 at 08:29 +0000, Martin Pool wrote:
> I would be very happy if you get it going; it will probably speed it
> up, make it more readable, and also let it work with foreign branches.
> The add code at the moment does a lot of manipulations on the
> inventory after reading it in, which makes it easy to keep track of
> things like adding parents before children, but it does also mean it's
> very tied to having mutable inventories.
>
> Perhaps we can pair on this at the sprint if you don't solve it
> beforehand.
I've done some investigation into it; mostly trying to get it to use
MutableTree.add(), but it seems like apply_inventory
the right way to go as some existing inventory entries might actually
have to change kind (files being replaced by directories, etc).
It'd be nice to pair on this, it should be reasonably easy.
Cheers,
Jelmer