Comment 3 for bug 172612

Revision history for this message
John A Meinel (jameinel) wrote :

We could:

a) Not show the revision number in the first line, so at least the data is different:
Committing to "/etc/".
modified postgresql/8.2/main/pg_hba.conf
modified postgresql/8.2/main/pg_ident.conf
Committed revision 37.

b) Not show the final line
Committing revision 37 to "/etc/".
modified postgresql/8.2/main/pg_hba.conf
modified postgresql/8.2/main/pg_ident.conf

c) Change the final line to not show the number:
Committing revision 37 to "/etc/".
modified postgresql/8.2/main/pg_hba.conf
modified postgresql/8.2/main/pg_ident.conf
Successful/Finished/Committed

d) Show the revision number at the beginning, and the revision id at the end
Committing revision 37 to "/etc/".
modified postgresql/8.2/main/pg_hba.conf
modified postgresql/8.2/main/pg_ident.conf
Committed revision: <email address hidden>

I don't see a huge problem with the repeated number, but I do understand that it seems a little redundant.
We've generally chosen to avoid printing revision ids unless specifically requested for them, so I think (d) is out.
I don't really like (b) because commits usually take a little while. Though I suppose having your prompt return might be enough of an indication that it has finished.
(a) is okay, it feels a bit like we know what will happen, go ahead and let the user know about it, but we don't have to.