Comment 13 for bug 503670

On Wed, Mar 3, 2010 at 12:10 PM, Martin Pool <email address hidden> wrote:
> I'm thinking about this a lot (see recent thread "plugins vs builtins"),
> and I think this actually doesn't need to be built in, just easily
> accessible.  A packaged plugin would satisfy this.  Also it may enable
> us to have it work on 2.1 or 2.0.
>

Yes. Thats certainly a big advantage of having it as a plugin.

> If Parth as the author strongly prefers it to be builtin, I wouldn't
> veto it just on the grounds that it _could_ be in a plugin.  Otherwise,
> I suggest we close this as wontfix.
>

I don't have a preference one way or another. Plugin works fine for
me. In fact I was thinking if it made sense of maintain a plugin even
if it became a builtin to make it available for 2.0/2.1.

One question though is how to we make the command easily available
to users but I suppose thats being discussed in the "plugins vs builtins"
thread.

> Of course he's still welcome to get code review on the code going into
> the plugin.
>
> --
> bzr grep should be builtin
> https://bugs.launchpad.net/bugs/503670
> You received this bug notification because you are a bug assignee.
>
> Status in Bazaar Version Control System: In Progress
>
> Bug description:
> james_w wrote:
>
> On Wed, 6 Jan 2010 09:42:04 +1100, Jonathan Lange <email address hidden> wrote:
>> Interestingly, I showed the recipe for bzr-tools-grep at UDS-L, and a
>> git fan in the audience sniggered about Bazaar's vaunted usability
>> because,
>>    "bzr ls -VR --kind=file --null | xargs -0 grep -In %s"
>>
>> becomes
>>   "git grep %s"
>>
>> Perhaps someone would like to add the grep command to bzr-core, or a plugin.
>
> You mean like lp:~vila/bzr/grep (confusingly a plugin under the bzr
> project?)
>
> I agree that it would be great to have it in core.
>
>
>
>
>