Comment 10 for bug 76616

2009/3/26 Jason Spashett <email address hidden>:
> I agree Martin, infact while I was developing the patch I realised that
> it was too verbose and indeed I mention the -v verbose option above that
> people may use if they are aware of it.
>
> This is a "trivial" bug, therefore I propose it be resolved without
> futher ado by:
>
> Adding a sentance or two to 'bzr help add', relating to ignored files.
> and, either;
>
> (1) Exactly what you propose above Martin, to keep the add ouput "clean"
>
> (2) Alternatively, I suggest:
> Print only (if there are ignored files):
> "Not adding 31 file(s) matched by ignore list."
>
> The use case for this is that someone may want to add .obj, .o, .so or
> .lib files (and other patterns, normally ignored), but find (too much
> later) that they have not been added and wonder why it may be, unaware
> of the -v option. At least with a simple diagnostic message they are
> notified of such; and they have enough to go on to notice and to rectify
> the situation.
>
> I am quite happy to submit another change on my branch that will
> implement either of these solutions. I leave the decision up to you
> Martin.

I think I'd still go for number one, for a few reasons:

- In general, we don't print out the count of files touched or
ignored. (Maybe someone wants to go and add --count everywhere but at
the moment no.)

- If you do have any intentionally ignored files, as most nontrivial
trees do, the count is just noise. Are you going to notice that it's
31 when it should be 27? Probably not.

- We now have no ignores by default, unlike when this code was first
written. So if nothing's configured to be ignored, there shoud be no
surprises.

- commit still defaults to verbose so you do get a definite clue there
that the thing you may have expected to be added was not.

So, just pull it out.

--
Martin <http://launchpad.net/~mbp/>