Comment 6 for bug 795481

Review:

Things to change:

- prefer the phpmyadmin package unless it's broken (please file bug if that's the case).

- Do you really mean to use 'chown -R www-data:www-data /var/www' for startup? If startup's a no-op, I'd recommend leaving it as a no-op. At the very least, please comment this to explain... it's unexpected. I'm thinking of somebody maintaining the charm in the future... don't make them hunt for what's going on.

Discussion/Recommendations:

- side note on CharmHelper... maybe move the templating into CH? I'd sure love for the process of: copy tpl, then sed vars
to be wrapped into a single apply_template() or something similar. Perhaps just use cheetah from the CLI? we'll discuss on #juju.

- no biggy at all, but maybe env/common could be lib/common.sh? That would make it clearer to me what it's for without having to read code.

- perhaps implement db-shared relation to provide phpmyadmin access to a single db? as per #juju

- perhaps a read-only config flag? as per #juju

cool man... thanks!