Comment 1 for bug 996361

Hi Alan!

Great first start for this Yacy charm! There are a few blockers that would need to be addressed before it can be submitted to the charm store.

= Blockers =

hooks/install
-----------------
All files that are lent to the installation of software (in this case the asc file for apt-key) need to be securely pulled or cryptographically checked. Since yacy doesn't provide an SSL certificate it's best to download the file yourself (and verify it's the correct key) then include it in the charm.

hooks/upgrade-charm
------------------------------
The current upgrade hook is called "upgrade" instead of "upgrade-charm" a rename will resolve this

hooks/config-changed
-------------------------------
The current configuration hook is in the root of the charm and not in the hooks folder. You'll need to move it in to the hooks folder and make it executable

COPYRIGHT
----------------
Every charm requires a copyright file, and for the charm to be licensed under an "Open" license. We recommend GPLv3 but any of the licenses under http://www.opensource.org/licenses/ are acceptable.

= Nitpicks and non-blockers =

metadata.yaml
--------------------
revision is depreciated in the metadata.yaml file (it's tracked in the revision file instead) as such the revision key should be removed from metadata.yaml

hooks/server-relation-*
--------------------------------
You specify that server is a relation that the charm provides, but there are no hooks for this relation. A hook will need to be created to accommodate this relation