Comment 2 for bug 1332539

Revision history for this message
James Page (james-page) wrote :

# neutron-openvswitch

## make lint

W: No icon.svg file.
W: no copyright file
W: no README file
I: missing recommended hook start
I: missing recommended hook stop
W: config.yaml: option rabbit-vhost does not have the keys: description
W: config.yaml: option rabbit-vhost has unknown keys: decsription

## hooks/neutron_ovs_utils.py

### register_configs

nova-common -> neutron-common - if we figure out a future use case which means nova is not on the same node this is more future proof.

### determine_packages

That's alot of code for what is essentially:

def determine_packages():
    return set(neutron_plugin_attribute('ovs', 'packages',
                                        'neutron'))

## hooks/neutron_ovs_context.py

We need to sort out the syslog and debug/verbose options as a general context helper - please make a # TODO comment there.

Comment on _neutron_security_groups is not quite correct - this comes from the neutron-api service.

## hooks/neutron_ovs_hooks.py

I'd probably skip the upgrade-charm hook - config-changed always gets called after upgrade charm anyway.