Comment 11 for bug 2035180

Hey David,

Thanks for the patches and SRU template, it looks good and to the point.

1) I'd just suggest to add more detail to 'Where problems could occur section'
(e.g., why is that a possible regression, and if there are other cases where
it wouldn't apply, say http only, or if a workaround is available if needed).

Regarding the debdiffs and .patch files -- mostly good too! Just a few points:

2) The version increment in Ubuntu stable releases is almost always '0.1'
(vs. '1' in Ubuntu development releases), see guide in [1].
For the Cloud Archive, the number in the ~cloudX suffix is incremented
(with '1' instead of '0.1' now :) instead of another ubuntuX(.Y) scheme at the end).

3) Some of the changelogs have an extra empty line before the signature.
Ah, and you may set TZ= for dch to pick up your timezone if you want.)
Bug number and patch file name format look good!

4) The git commit/patch format provides most fields (see Standard Fields in DEP3 [2];
e.g., Description/Subject, Origin/Author/From, Bug-Ubuntu), and only 'Origin:' and
'Bug-Ubuntu:' are usually required for Ubuntu SRUs, in addition.

Origin: ideally points to the commit merged upstream (instead of a review/issue/pr),
and has the 'backport' keyword (vs. 'upstream') only if changes were needed for the
patch to apply in the Ubuntu package (instead of whether the upstream commit itself
is a backport of an upstream change introduced in later versions).

Thanks again,
Mauricio

[1] https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging
[2] https://dep-team.pages.debian.net/deps/dep3/