gnome-background-properties uses a "Finish" button instead of "Close"

This small patch fixes the issue.

How you can see from the upstream bug you pointed that's an upstream decision and dobey argue that Novel did usuability tests that pointed that as an useful change

Maybe you could raise the topic on the ubuntu-desktop list? That would be better than a bug tracker to get people noticing the topic and argumenting

Did I say something about usability tests of Novell? I don't think so. From my point of view there is no need for discussion. The dialog violates the GNOME desktop conventions. And using "finish" instead of "close" in all GNOME dialogs is really out of scope for edgy.

Just for the archives:

Here is the original bug about instant/explicit apply:

http://bugzilla.gnome.org/show_bug.cgi?id=327335

And a related maling list discussion:

http://mail.gnome.org/archives/desktop-devel-list/2006-January/msg00479.html

Le samedi 16 septembre 2006 à 17:39 +0000, Sebastian Heinlein a écrit :
> Did I say something about usability tests of Novell?

no, but dobey works for them and when he writes "Yes, it is now Finish
as a result of direct usability testing" he's speaking about that

I think I should not answer comments when I arrive at home from working. Reading twice sometimes helps :)

It is of course debatable whether 'Close' or 'Finish' is better in this case, but as it is a minor issue we would rather not carry a delta with upstream over it. If you feel strongly about it, please lobby upstream. Thanks.