Ubuntu
geg package

[PATCH] adding a .desktop file to geg

Bug #5399 reported by Thierry Moisan
10
Affects Status Importance Assigned to Milestone
geg (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

following https://wiki.ubuntu.com/UniversePackageWithoutDesktopFile, I added a .desktop file to the geg package.

Revision history for this message
Thierry Moisan (thierryn) wrote : proposed patch

I used the xine.xpm as icon, since it was looking good.

Daniel Holbach (dholbach)
Changed in geg:
assignee: nobody → motureviewers
Revision history for this message
Andrew Mitchell (ajmitch) wrote :

+geg (1.0.2-5) unstable; urgency=low

should rather be

+geg (1.0.2-4ubuntu1) dapper; urgency=low

to indicate that it's an ubuntu change, targetted for dapper.

Revision history for this message
Raphaël Pinson (raphink) wrote :

The .desktop file also lacks GenericName entries to be freedesktop.org compliant.

Revision history for this message
Thierry Moisan (thierryn) wrote : second patch

I made the changes following the two last comments.

Revision history for this message
Benjamin Montgomery (bmonty) wrote : package version

I think the correct version should be:

geg (1.0.2-5ubuntu1) dapper; urgency=low

dapper has version 1.0.2-5 without the new desktop file. Also make sure that the debdiff is against the dapper souce package.

Revision history for this message
Thierry Moisan (thierryn) wrote : third patch

I made the change on the dapper package, and I changed the version number

Revision history for this message
Jeroen (jeroenubuntu) wrote :

+ dh_install src/pixmaps/sine.xpm usr/share/pixmaps

xine.xpm or sine.xpm?

And you're lacking a GenericName

Revision history for this message
Thierry Moisan (thierryn) wrote : fourth patch

I added the GenericName. This is really sine.xpm, it's a picture in the source wich I tough would do a great icon.

Zak B. Elep (zakame)
Changed in geg:
status: Unconfirmed → In Progress
Revision history for this message
Zak B. Elep (zakame) wrote :

Tried to build this; it went fine, but it doesn't install the .desktop file to the proper location. Furthermore, the pixmaps aren't installed---this is perhaps a separate bug.

Revision history for this message
Thierry Moisan (thierryn) wrote : fifth patch

Ok, this one should solve the problem.

Revision history for this message
LaserJock (laserjock) wrote :

Released (geg-1.0.2-5.1ubuntu1) for dapper. Thanks Thierry.

Changed in geg:
status: In Progress → Fix Released
Revision history for this message
Reinhard Tartler (siretart) wrote :

debian has just included this desktop file

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.