menu icons missing

Bug #43337 reported by KarlGoetz
18
Affects Status Importance Assigned to Milestone
hubackup (Ubuntu)
Fix Released
Low
Siegfried Gevatter

Bug Description

The icons for Home User Backup and Home User Restore in System -> Administration are missing.
There appears to be no icons (PNGs) in the source package at all.

Tags: bitesize

Related branches

Revision history for this message
Sivan Greenberg (sivan) wrote :

Confirmed. I need to check with the art team if they can make something up, or use some I created myself.

Sivan Greenberg (sivan)
Changed in hubackup:
status: Unconfirmed → Confirmed
Revision history for this message
Sebastian Heinlein (glatzor) wrote :

I think that lapo already works on icons.

Regrads,

Sebastian

Revision history for this message
Sivan Greenberg (sivan) wrote :

Sub'd the art team to see if they can help. I hope it's okay and I'm not spamming them too much.

Revision history for this message
Stephen Eisenhauer (bhspitmonkey) wrote :

WIP Design based on Tango icons

Changed in hubackup:
assignee: nobody → schwitzd
Changed in hubackup:
assignee: schwitzd → nobody
Changed in hubackup:
assignee: nobody → schwitzd
Revision history for this message
Daniel Schwitzgebel (schwitzd) wrote :

Attached debdiff should fix this bug

Changed in hubackup:
assignee: schwitzd → nobody
Revision history for this message
Daniel Holbach (dholbach) wrote :

Sivan: can you get this included and uploaded?

Changed in hubackup:
assignee: nobody → sivan
Revision history for this message
Áron Sisak (asisak) wrote :

Do we really need to change files outside the debian/ directory?
I think you should not change upstream version.

Revision history for this message
Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount) wrote :

That .desktop file is not ok, Encoding field is deprecated.

Revision history for this message
Siegfried Gevatter (rainct) wrote :

Are you still working on this?

Revision history for this message
David Cordero (david.cordero) wrote : Fix format
Changed in hubackup:
assignee: sivan → nobody
Changed in hubackup:
importance: Medium → Low
Revision history for this message
Siegfried Gevatter (rainct) wrote :

This is a native Ubuntu package, so version number should be 0.0.8. Because of this, and that it has already and @ubuntu.com address, you don't need to change the Maintainer field. Also, please call dh_desktop in debian/rules.

Please re-subscribe ubuntu-universe-sponsors once you have addressed those issues.

Thanks for contributing to Ubuntu! :)

Revision history for this message
Siegfried Gevatter (rainct) wrote :

Ah, I forgot to say that the current standards version is 3.7.3 so, if you change it, use that one (instead of 3.7.2.2). And that the "format problems" you had with your last uploads were because you didn't check the "This attachment is a patch" when you uploaded them; please do this next time :).

Changed in hubackup:
assignee: nobody → dcordero
status: Confirmed → In Progress
Revision history for this message
David Cordero (david.cordero) wrote :

So, i can't change the version to 0.0.8 because i am not the mainteiner.

If i have to keep the mainteiner i can only to create a 0.0.7-1 as NMU

At least that tell me lintian. Anyway there is the new debdiff with all the changes, but with that lintian warning:

Changed in hubackup:
assignee: dcordero → nobody
status: In Progress → Confirmed
Revision history for this message
David Cordero (david.cordero) wrote :

NMU problems fixed and Comments added to .desktop

Changed in hubackup:
assignee: nobody → rainct
Revision history for this message
David Cordero (david.cordero) wrote :

Some problem on debdiff fixed

Revision history for this message
Siegfried Gevatter (rainct) wrote :

RainCT: dcordero: okay. I've just noticed, why do you add a .desktop file if it's already installing two? (those in build/)
RainCT: dcordero: modify those instead (just edit them directly, as it's a native package it needs no patch system) to add the Icon=hubackup
RainCT: (and update them to the newest standards on the way, like removing Encoding=)
RainCT: dcordero: also, in the changelog leave an empty line before the first point (like in all other entries there), and add "(LP: #43337)" to the line about the icons (to let Launchpad automatically close the bug)

I'll upload your changes once this is fixed :).

Changed in hubackup:
assignee: rainct → dcordero
status: Confirmed → In Progress
Revision history for this message
David Cordero (david.cordero) wrote :

What is the best way, patch the .desktop files or change the original files?

i read that the mainteiner never must change the originals files.

Revision history for this message
Siegfried Gevatter (rainct) wrote :

True, but as this is a native package (which has no .diff.gz) the right think here is to just change it directly.

Revision history for this message
David Cordero (david.cordero) wrote :

New debdiff with all these changes

Changed in hubackup:
assignee: dcordero → nobody
status: In Progress → Confirmed
Changed in hubackup:
assignee: nobody → rainct
status: Confirmed → In Progress
Revision history for this message
David Cordero (david.cordero) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package hubackup - 0.0.8

---------------
hubackup (0.0.8) hardy; urgency=low

  * Fixed .desktop files
  * Added icon debian/hubackup.svg (LP: #43337)

 -- David Cordero <email address hidden> Tue, 29 Jan 2008 22:51:17 +0100

Changed in hubackup:
status: In Progress → Fix Released
Revision history for this message
Siegfried Gevatter (rainct) wrote :

Package uploaded. Thanks for contributing to Ubuntu! :)

Changed in hubackup:
status: Fix Released → Fix Committed
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.