libsane.rules: Line 540 too long, can not be parsed by udev

Bug #56317 reported by Thom May
36
Affects Status Importance Assigned to Milestone
sane-backends
Fix Released
Unknown
sane-backends (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Udevd startup reports a "line too long" warning for line 540 of 45-libsane.rules. However, line 540 is a comment:

# Artec/Ultima Ultima 2000 | Artec/Ultima Ultima 2000 e+ | Boeder Sm@rtScan Slim Edition | Fujitsu 1200CUS | Googlegear 2000 | Medion/Lifetec/Tevion/Cytron MD 4394 | Medion/Lifetec/Tevion/Cytron MD/LT 9375 | Medion/Lifetec/Tevion/Cytron MD/LT 9385 | Medion/Lifetec/Tevion/Cytron LT 9452 | Medion/Lifetec/Tevion/Cytron MD 9458 | Mustek BearPaw 1200 CU | Mustek BearPaw 2400 CU | Mustek ScanExpress 1200 UB Plus | Mustek ScanExpress 2400 USB | Mustek ScanMagic 1200 UB Plus | Packard Bell Diamond 1200 | Trust Compact Scan USB 19200 | Trust Flat Scan USB 19200

So it's not clear to me why udev is parsing the line at all. It also says that it's skipping the line, making the warning look a lot more serious than the problem actually is.

Revision history for this message
Bruno (bruno666-666) wrote :

I confirm this bug.

However it seems to be fixed in Debian, see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=376859

Changed in sane-backends:
status: Unconfirmed → Confirmed
Changed in sane-backends:
status: Unknown → Fix Released
Revision history for this message
Rocco Stanzione (trappist) wrote :

I figure since the error message is incorrect (the comment is not a "rule" that needs to be skipped), the correct solution is to filter out comments before trying to parse. I haven't tested this (not sure how to), but this patch should cause it to skip comments. I just moved the check for comment characters from after the check for too-long-lines to before it.

Revision history for this message
Daniel T Chen (crimsun) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue, 05 Sep 2006 11:13:22 +0100
Source: sane-backends
Binary: libsane-dev sane-utils libsane-dbg libsane
Architecture: source
Version: 1.0.18-3ubuntu1
Distribution: edgy
Urgency: low
Maintainer: Julien BLACHE <email address hidden>
Changed-By: Daniel T Chen <email address hidden>
Description:
 libsane - API library for scanners
 libsane-dbg - API development library for scanners [debug symbols]
 libsane-dev - API development library for scanners [development files]
 sane-utils - API library for scanners -- utilities
Closes: 376859
Changes:
 sane-backends (1.0.18-3ubuntu1) edgy; urgency=low
 .
   * Merge from Debian unstable. The remaining Ubuntu changes are:
     - debian/{libsane,sane-utils}.README.Debian: Remove hotplug
       references,
     - debian/{libsane.dirs.linux,rules}: Ship udev rules only,
     - debian/libsane.postinst: Clean up old hotplug directories
       (not bailing where they're non-empty),
     - debian/patches/30_udev_long_comment_lines.dpatch: Prefer
       to debian/patches/25_udev_rules_line_length.dpatch,
     (Closes Ubuntu: #56317, #59141, #59390, #59753).
 .
 sane-backends (1.0.18-3) unstable; urgency=low
 .
   * debian/patches/30_udev_long_comment_lines.dpatch:
     + Added; split very long comment lines in the udev rules file
       (closes: #376859).
   * debian/libsane.README.Debian:
     + Updated; udev no longer sets permissions on /proc/bus/usb/xxx/yyy,
       /dev/bus/usb/xxx/yyy is used instead now.
Files:
 e632fde114cb2d2bc56f308106b47a96 952 graphics optional sane-backends_1.0.18-3ub
untu1.dsc
 3c4363ad95381f29e6f2664a5fe458a3 29883 graphics optional sane-backends_1.0.18-3
ubuntu1.diff.gz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQFFBIFte9GwFciKvaMRAgqtAKCfOOS4htjuY+GCn+h2/5dAMwooqwCeOFp7
qXaQXpzdePC1IklA7ei+49g=
=PaDO
-----END PGP SIGNATURE-----

Changed in sane-backends:
importance: Untriaged → Wishlist
status: Confirmed → Fix Committed
Daniel T Chen (crimsun)
Changed in sane-backends:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.