Ubuntu
xmms package

Extra xmms-skins are not available for selection

Bug #3208 reported by Konrad L
18
Affects Status Importance Assigned to Milestone
xmms (Ubuntu)
Fix Released
Low
MOTU
Ubuntu ubuntu-6.06

Bug Description

Hello,

I think that this can be considered a BUG (easily fixable). After installing xmms-skins package the default location of the skins is "/usr/share/XMMS/Skins/". This location is not specified in xmms skin configuration window (though this location is xmms' default: "~/.xmms/Skins/").

Simple fix was just adding the "/usr/share/XMMS/Skins/" directory to the "Skin selector" in XMMS. I'm not sure if this location can be added automatically by this package. I guess simpler solution would be to install xmms-skins to ~/.xmms/Skins/ as a default location...

Thanks

Sebastien Bacher (seb128)
Changed in xmms-skins:
assignee: nobody → motu
Revision history for this message
Kristian Vlaardingerbroek (kristianv) wrote :

The 10_all_skin-dir-browser debian patch removes the default DATA_DIR/Skins (in our case /usr/share/XMMS/Skins) path, and also the support for the SKINSDIR environment variable. This breaks with what the XMMS man page tells and looks like it needs to be fixed.

Benjamin Montgomery (bmonty)
Changed in xmms-skins:
status: Unconfirmed → Confirmed
Revision history for this message
Benjamin Montgomery (bmonty) wrote : problem description

This bug is caused by the way xmms reads in the config file. If no config file exists the code adds the DATA_DIR/Skins and .xmms/Skins directories to the list of directories that xmms will search for skin files. The next time xmms is started the code assumes that the two directories are already saved in the config file and will be read in. I think the problem is that if the config file doesn't get saved properly when xmms does the initial creation of the skin directories, they will never appear in the skin browser unless the user adds them.

Revision history for this message
Benjamin Montgomery (bmonty) wrote : patch issues

Also, 10_all_skin-dir-browser did create a bug with the default skin paths, but 29_all_default_skin_fix fixed the bug and introduced the more subtle bug we see now.

Revision history for this message
Yann Rouillard (yann-pleiades) wrote :

I deleted my .xmms directory and relaunched xmms and /usr/share/XMMS/Skins is correctly added in the directories list. I closed and relaunched xmms and /usr/share/XMMS/Skins was still in the directory list (I check the config file as well).

So there's no more bug, the problem I think is that this directory is only added if no config file exists, so a user who has .xmms/config file before would never have /usr/share/XMMS/Skins automatically in his directory path.

Revision history for this message
Benjamin Montgomery (bmonty) wrote :

Yann, see my comment above :)

There is still a bug, xmms should always have the default paths regardless of how it was opened or closed.

Revision history for this message
Benjamin Montgomery (bmonty) wrote : patch

I have a patch that fixes this problem. I'll upload it as soon as I'm done testing.

Revision history for this message
Benjamin Montgomery (bmonty) wrote :

This patch makes the default skin paths always appear in the skin browser.

Changed in xmms:
status: Confirmed → In Progress
Revision history for this message
Marco da Silva (igama) wrote :

FIxed in Feisty

Changed in xmms:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Patches

Remote bug watches

Bug watches keep track of this bug in other bug trackers.