Comment 7 for bug 1068646

A. I think the supplied solution in a simplest and minimally disruptive way improves consistency of terms at the interface level. The patch fixes the bug with the least effort and side-effects, although I agree the result is not perfect.

I do not have a lot of time that I can spend on this issue right now, but if I recall correctly from the time when I worked on it, the replacements made in the patch were the only few instances of the word "Physical" that were used in the front-end interface -- whereas everywhere else the term "Billing" was used, including on the registration interface. The back-end is a bit more of a soup, but in the database corresponding fields in actor.usr are currently labelled "mailing_address" and "billing_address". I think of the database schema as sort of a basic "truth" as a point of reference, which in this case helped me choose the direction.

I suggest we move ahead with this patch as-is or otherwise mark this bug as "won't fix". Maybe I am overanalyzing this a bit, but theoretically, even if someone wants to make a patch with from "Billing" to "Physical" renaming for the patron interface, I imagine that could create far more inconsistencies with other interface areas and possibly additional issues for documentation materials as well. To rename from "Billing" to "Physical" everywhere may require quite a bit of work, perhaps disproportionate to the level of the bug.

B. Considering the lifecycle stage of the current staff client and regardless of the resolution of this bug, perhaps it could be useful to have a comprehensive discussion/analysis of the various current and future (e.g. for academic) library preferences and needs for address types. That discussion may well lead to exactly where we're at now, but with the development of the new web-based staff client this could be a perfect time to (re)evaluate this topic with the idea that any significant changes would be implemented in the new web-based interface. If there is any interest, I am willing to start that discussion in the form of a bug and/or some other medium and to contribute work towards implementation.